8000 dev-utils: extract method for serializing the proof to file by m-kus · Pull Request #955 · starkware-libs/stwo-cairo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dev-utils: extract method for serializing the proof to file #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

m-kus
Copy link
Collaborator
@m-kus m-kus commented May 28, 2025

To reuse in cairo-prove


This change is Reviewable

@m-kus m-kus requested a review from ohad-agadi May 28, 2025 11:19
Copy link
Collaborator
@ohad-agadi ohad-agadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


stwo_cairo_prover/crates/dev_utils/src/utils.rs line 117 at r1 (raw file):

    Ok(())
}

put it here

Copy link
Collaborator Author
@m-kus m-kus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @ohad-agadi)


stwo_cairo_prover/crates/dev_utils/src/utils.rs line 117 at r1 (raw file):

Previously, ohad-agadi (Ohad) wrote…

put it here

Done.

Copy link
Collaborator
@ohad-agadi ohad-agadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 8 files at r2, all commit messages.
Reviewable status: 4 of 8 files reviewed, 1 unresolved discussion


-- commits line 4 at r2:
squash

@m-kus m-kus force-pushed the m-kus/dev-utils-serde branch from 404094e to 7a62e9e Compare June 5, 2025 14:00
Copy link
Collaborator Author
@m-kus m-kus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 8 files reviewed, 1 unresolved discussion (waiting on @ohad-agadi)


-- commits line 4 at r2:

Previously, ohad-agadi (Ohad) wrote…

squash

Done.

Copy link
Collaborator
@ohad-agadi ohad-agadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @m-kus)

@m-kus m-kus merged commit 62c3c4a into main Jun 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0