Utility function to generate preprocessed tree roots #940
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ohad-agadi)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions
stwo_cairo_prover/crates/prover/src/witness/utils.rs line 158 at r1 (raw file):
) .into_iter() .collect_vec();
vec -> iter -> vec?
Code quote:
.into_iter()
.collect_vec();stwo_cairo_prover/crates/prover/src/witness/utils.rs line 175 at r1 (raw file):
.join(", "); info!("log_blowup_factor: {}, blake root: [{}]", i + 1, hex_string);
why log? you are now dependent on the user to have a subscriber
don't you just want to print here?
stwo_cairo_prover/crates/prover/src/witness/utils.rs line 176 at r1 (raw file):
info!("log_blowup_factor: {}, blake root: [{}]", i + 1, hex_string); });
Suggestion:
// Blake2s roots.
let blake_roots = get_preprocessed_roots::<Blake2sMerkleChannel>(
max_log_blowup_factor,
PreProcessedTraceVariant::Canonical,
);
blake_roots.iter().enumerate().for_each(|(i, root)| {
let root_bytes = root.0;
let u32s_hex = root_bytes
.array_chunks::<4>()
.map(|&bytes| u32::from_le_bytes(bytes))
.map(|u32| format!("{:#010x}", u32))
.collect_vec()
.join(", ");
info!("log_blowup_factor: {}, blake root: [{}]", i + 1, u32s_hex);
});There was a problem hiding this comment.
dam you merged
Reviewable status: all files reviewed, 3 unresolved discussions
This change is