Change RelationUse uses type to u64 #935
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions
stwo_cairo_prover/crates/cairo-air/src/verifier.rs line 68 at r1 (raw file):
let mut relation_uses = HashMap::<&'static str, u64>::new(); claim.accumulate_relation_uses(&mut relation_uses); log::info!("relation_uses: {:?}", relation_uses);
debug of hashmap is very ugly
write a function
stwo_cairo_prover/crates/cairo-air/src/verifier.rs line 71 at r1 (raw file):
for (name, uses) in relation_uses { assert!(uses < PRIME.into(), "Relation {} has {} uses.", name, uses); }
wdyt?
Suggestion:
let outstanding_relations = relations.iter().filter(|(_,uses) uses < PRIME).collect();
match outstanding_relations.len() { 1... => panic with verbose message}There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @alon-f)
stwo_cairo_prover/crates/cairo-air/src/air.rs line 156 at r1 (raw file):
} pub fn accumulate_relation_uses(&self, relation_counts: &mut HashMap<&'static str, u64>) {
consider typedef
Code quote:
HashMap<&'static str, u64>52f7be5 to
e767bc0
Compare
e767bc0 to
0ff768a
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @ohad-agadi)
stwo_cairo_prover/crates/cairo-air/src/air.rs line 156 at r1 (raw file):
Previously, ohad-agadi (Ohad) wrote…
consider typedef
Done
stwo_cairo_prover/crates/cairo-air/src/verifier.rs line 68 at r1 (raw file):
Previously, ohad-agadi (Ohad) wrote…
debug of hashmap is very ugly
write a function 8000
Done.
stwo_cairo_prover/crates/cairo-air/src/verifier.rs line 71 at r1 (raw file):
Previously, ohad-agadi (Ohad) wrote…
wdyt?
Done.
There was a problem hiding this comment.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alon-f)
There was a problem hiding this comment.
Reviewable status:
This change is