add dev_utils craate and vm_adapter_prover binary #909
Conversation
ffb1b3b to
750e51d
Compare
34a5311 to
cb06624
Compare
There was a problem hiding this comment.
it doesnt make sense to have a main here
you want to crate separate binary targets in the crate. so you don't have to compile everything for anything.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @anatgstarkware)
750e51d to
8babf70
Compare
cb06624 to
614f246
Compare
8babf70 to
6d40d39
Compare
614f246 to
a2000ef
Compare
6d40d39 to
9f277eb
Compare
a2000ef to
8adeb2d
Compare
9f277eb to
f21a8a4
Compare
8adeb2d to
883d669
Compare
f21a8a4 to
64f6e4e
Compare
e03e0f5 to
c327e18
Compare
c327e18 to
e85daf6
Compare
There was a problem hiding this comment.
Fixed
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @anatgstarkware)
e85daf6 to
48fecc5
Compare
There was a problem hiding this comment.
Reviewed 1 of 6 files at r3, all commit messages.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware)
stwo_cairo_prover/crates/dev_utils/Cargo.toml line 2 at r3 (raw file):
[package] name = "vm_adapter_prover"
dev-utils
48fecc5 to
1b52feb
Compare
b34d08f to
5711490
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware and @ohad-agadi)
stwo_cairo_prover/crates/dev_utils/Cargo.toml line 2 at r3 (raw file):
Previously, ohad-agadi (Ohad) wrote…
dev-utils
Done.
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 2 unresolved discussions (waiting on @anatgstarkware)
stwo_cairo_prover/crates/dev_utils/Cargo.toml line 7 at r4 (raw file):
[features] std = ["stwo-cairo-adapter/std"]
Remove, take the adapter with std
5711490 to
3d469af
Compare
There was a problem hiding this comment.
Reviewed 2 of 6 files at r3, 2 of 3 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @anatgstarkware)
stwo_cairo_prover/crates/dev_utils/Cargo.toml line 16 at r5 (raw file):
stwo-prover.workspace = true stwo_cairo_prover.workspace = true stwo_cairo_utils.workspace = true
remove the dependency and copy the code here
or better- rewrite the stuff you need properly.
stwo_cairo_prover/crates/dev_utils/src/bin/vm_adapter_prover.rs line 9 at r5 (raw file):
use tracing::{span, Level}; // Command line arguments for adapted_stwo.
rename to:
prove_from_artifacts
adapted_stwo/adapted_prover is cringe
stwo_cairo_prover/hi line 0 at r5 (raw file):
remove
3d469af to
2aa49c4
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 7 files reviewed, 3 unresolved discussions (waiting on @anatgstarkware and @ohad-agadi)
stwo_cairo_prover/crates/dev_utils/Cargo.toml line 7 at r4 (raw file):
Previously, ohad-agadi (Ohad) wrote…
Remove, take the adapter with std
Done.
stwo_cairo_prover/crates/dev_utils/Cargo.toml line 16 at r5 (raw file):
Previously, ohad-agadi (Ohad) wrote…
remove the dependency and copy the code here
or better- rewrite the stuff you need properly.
Done.
stwo_cairo_prover/hi line at r5 (raw file):
Previously, ohad-agadi (Ohad) wrote…
remove
Done.
stwo_cairo_prover/crates/dev_utils/src/bin/vm_adapter_prover.rs line 9 at r5 (raw file):
Previously, ohad-agadi (Ohad) wrote…
rename to:
prove_from_artifacts
adapted_stwo/adapted_prover is cringe
I called it 'vm_prover_adapter', just forgot this part in the doco
There was a problem hiding this comment.
Reviewed 2 of 5 files at r6.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware and @Stavbe)
stwo_cairo_prover/crates/dev_utils/src/bin/vm_adapter_prover.rs line 9 at r5 (raw file):
Previously, Stavbe wrote…
I called it 'vm_prover_adapter', just forgot this part in the doco
still cringe
2aa49c4 to
bd270dc
Compare
There was a problem hiding this comment.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware and @ohad-agadi)
stwo_cairo_prover/crates/dev_utils/src/bin/vm_adapter_prover.rs line 9 at r5 (raw file):
Previously, ohad-agadi (Ohad) wrote…
still cringe
Done.
There was a problem hiding this comment.
Reviewed 2 of 5 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @anatgstarkware)
This change is