Remove range check 3,6 #889
Conversation
c23e19c to
8d300e1
Compare
There was a problem hiding this comment.
Reviewed 1 of 14 files at r1, all commit messages.
Reviewable status: 1 of 14 files reviewed, 1 unresolved discussion (waiting on @DavidLevitGurevich)
a discussion (no related file):
Do you think there would be more changes the preprocessed trace?
Previously, shaharsamocha7 wrote…
Yes, should I do that in this pr? |
Previously, anatgstarkware (anatg) wrote…
Done |
0342510 to
e39c7e0
Compare
There was a problem hiding this comment.
Reviewed 8 of 14 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)
stwo_cairo_prover/crates/cairo-air/src/components/constraints_regression_test_values.rs line 49 at r2 (raw file):
pub const RANGE_CHECK_BUILTIN_BITS_128: QM31 = qm31!(98318865, 510635574, 1814943674, 477505709); pub const RANGE_CHECK_FELT_252_WIDTH_27: QM31 = qm31!(82213281, 219376879, 729002900, 792303124); pub const RANGE_CHECK_6: QM31 = qm31!(1839596244, 1029136098, 314080530, 1911163288);
why did these regressions change too?
|
Previously, DavidLevitGurevich wrote…
because I changed them to use |
e39c7e0 to
7fb8cd6
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @anatgstarkware)
stwo_cairo_prover/crates/cairo-air/src/preprocessed.rs line 150 at r3 (raw file):
Box::new(range_check_19), Box::new(range_check_3_6_col_0), Box::new(range_check_3_6_col_1),
what's that change?
Code quote:
Box::new(range_check_6),
Box::new(range_check_8),
Box::new(range_check_11),
Box::new(range_check_12),
Box::new(range_check_18),
Box::new(range_check_19),
Box::new(range_check_3_6_col_0),
Box::new(range_check_3_6_col_1),stwo_cairo_prover/crates/cairo-air/src/components/constraints_regression_test_values.rs line 54 at r3 (raw file):
pub const RANGE_CHECK_12: QM31 = qm31!(2029705150, 1702041781, 1878593402, 1237923315); pub const RANGE_CHECK_18: QM31 = qm31!(160488628, 2118914040, 1869606781, 508250040); pub const RANGE_CHECK_19: QM31 = qm31!(1263070117, 595729633, 939215182, 505220046);
why all of those were changed?
Code quote:
pub const RANGE_CHECK_6: QM31 = qm31!(1839596244, 1029136098, 314080530, 1911163288);
pub const RANGE_CHECK_8: QM31 = qm31!(619380186, 51892308, 1959448152, 27164417);
pub const RANGE_CHECK_11: QM31 = qm31!(1797671535, 1448714071, 655307656, 610124137);
pub const RANGE_CHECK_12: QM31 = qm31!(2029705150, 1702041781, 1878593402, 1237923315);
pub const RANGE_CHECK_18: QM31 = qm31!(160488628, 2118914040, 1869606781, 508250040);
pub const RANGE_CHECK_19: QM31 = qm31!(1263070117, 595729633, 939215182, 505220046);There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @anatgstarkware)
This change is