Replace range_check_vector with separate rcs #881
Conversation
There was a problem hiding this comment.
Reviewed 32 of 33 files at r1, all commit messages.
Reviewable status: 32 of 33 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
stwo_cairo_verifier/crates/cairo_air/src/components/range_check_9_9.cairo line 36 at r1 (raw file):
let preprocessed_log_sizes = array![log_size].span(); let trace_log_sizes = ArrayImpl::new_repeated(N_TRACE_COLUMNS, log_size).span(); let interaction_log_sizes = ArrayImpl::new_repeated(4, log_size).span();
use constant
Suggestion:
let interaction_log_sizes = ArrayImpl::new_repeated(QM31_EXTENSION_SOMETHING, log_size).span();stwo_cairo_verifier/crates/cairo_air/src/components/range_check_9_9.cairo line 42 at r1 (raw file):
fn mix_into(self: @Claim, ref channel: Channel) { channel.mix_u64((LOG_SIZE).into()); }
It's not what we used to mix for range checks
Code quote:
fn mix_into(self: @Claim, ref channel: Channel) {
channel.mix_u64((LOG_SIZE).into());
}8246b8d to
692b1c3
Compare
There was a problem hiding this comment.
Reviewable status: 15 of 33 files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
stwo_cairo_verifier/crates/cairo_air/src/components/range_check_9_9.cairo line 42 at r1 (raw file):
Previously, shaharsamocha7 wrote…
It's not what we used to mix for range checks
Irrelevant since we removed the mixing of preprocessed
692b1c3 to
4a5f3c8
Compare
|
Previously, shaharsamocha7 wrote…
This is the same as in other components, I'll fix in a different pr |
3cf47ff to
3cfc6c5
Compare
3cfc6c5 to
b96e734
Compare
There was a problem hiding this comment.
Reviewed 17 of 18 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @andrewmilson)
stwo_cairo_verifier/crates/cairo_air/src/components/range_check_3_6_6_3.cairo line 101 at r3 (raw file):
let column_size = m31(pow2(log_size)); let mut range_check_3_6_6_3_sum_0: QM31 = Zero::zero(); let rangecheck_3_6_6_3_0 = preprocessed_mask_values
Is this name intended? or do we want to change it?
Code quote:
rangecheck_3_6_6_3_0stwo_cairo_prover/crates/cairo-air/src/components/range_check_vector.rs line 59 at r3 (raw file):
#[derive(Clone, Deserialize, Serialize, CairoSerialize)] pub struct Claim { pub log_ranges: Vec<u32>,
Why this change? or is it still in use?
Aren't we discarding this file?
Code quote:
pub log_ranges: Vec<u32>,stwo_cairo_verifier/crates/cairo_air/src/components/range_check_12.cairo line 76 at r1 (raw file):
let trace_gen = CanonicCosetImpl::new(log_size).coset.step_size; let point_offset_neg_1 = point.add_circle_point_m31(-trace_gen.mul(1).to_point());
consider to re-add this empty line
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
stwo_cairo_prover/crates/cairo-air/src/components/range_check_vector.rs line 59 at r3 (raw file):
Previously, shaharsamocha7 wrote…
Why this change? or is it still in use?
Aren't we discarding this file?
this is in the prover
stwo_cairo_verifier/crates/cairo_air/src/components/range_check_3_6_6_3.cairo line 101 at r3 (raw file):
Previously, shaharsamocha7 wrote…
Is this name intended? or do we want to change it?
This is the first column in the preprocessed table. Since we didn't separate column index from the rest of the args to preprocessed columns, we are stuck with this name.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anatgstarkware and @andrewmilson)
This change is