Make starbeam smaller / faster #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
144cd51 to
5761fd2
Compare
1899223 to
2af9405
Compare
NullVoxPopuli
commented
Jan 9, 2024
| @@ -31,6 +31,9 @@ export default (mode = process.env["MODE"] ?? "development"): RollupPlugin => { | |||
| return createReplacePlugin( | |||
| (id) => /\.(j|t)sx?$/.test(id), | |||
| { | |||
| // remove inline testing | |||
| "import.meta.vitest": "false", | |||
There was a problem hiding this comment.
we don't want to include in-source tests in any output code
NullVoxPopuli
commented
Jan 9, 2024
| @@ -113,16 +113,27 @@ export default function typescript( | |||
| }; | |||
|
|
|||
| const minify = { | |||
| format: { | |||
| comments: mode === 'production', | |||
There was a problem hiding this comment.
turns out, SWC doesn't actually remove comments 😅
NullVoxPopuli
commented
Jan 9, 2024
| @@ -1,6 +1,7 @@ | |||
| import { execSync } from 'node:child_process'; | |||
| import { join, resolve } from "node:path"; | |||
|
|
|||
| import terser from '@rollup/plugin-terser'; | |||
There was a problem hiding this comment.
used for removing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with starbeamjs/starbeam#149