8000 Draft: Conditional compilation of Package parts by DivineDominion · Pull Request #144 · stackotter/swift-cross-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Draft: Conditional compilation of Package parts #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
8000
from
Open

Draft: Conditional compilation of Package parts #144

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4981ee
fanout AppKit, UIKit, WinUI backend product and targets with conditio…
DivineDominion May 10, 2025
42ff956
move Windows dependencies into conditional compilation block
DivineDominion May 10, 2025
b10dc60
add and configure SwiftCrossUITests per host OS
DivineDominion May 10, 2025
4d67b07
split off GTK detection and compilation during swift build
DivineDominion May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 133 additions & 61 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ if let version = getGtk4MinorVersion(), version >= 10 {
gtkSwiftSettings.append(.define("GTK_4_10_PLUS"))
}

// On macOS, test both code paths with `brew unlink gtk4`, `brew link gtk4` to make the lookup fail/succeed.
let didFindGTK4 = getGtk4MinorVersion() != nil
let didFindGTK3 = isGtk3Installed()

let defaultBackend: String
if let backend = ProcessInfo.processInfo.environment["SCUI_DEFAULT_BACKEND"] {
defaultBackend = backend
Expand All @@ -20,7 +24,13 @@ if let backend = ProcessInfo.processInfo.environment["SCUI_DEFAULT_BACKEND"] {
#elseif os(Windows)
defaultBackend = "WinUIBackend"
#else
defaultBackend = "GtkBackend"
if didFindGTK4 {
defaultBackend = "GtkBackend"
} else if didFindGTK3 {
defaultBackend = "Gtk3Backend"
} else {
fatalError("Neither GTK4 not GTK3 found")
}
#endif
}

Expand Down Expand Up @@ -64,24 +74,12 @@ let package = Package(
platforms: [.macOS(.v10_15), .iOS(.v13), .tvOS(.v13), .macCatalyst(.v13)],
products: [
.library(name: "SwiftCrossUI", type: libraryType, targets: ["SwiftCrossUI"]),
.library(name: "AppKitBackend", type: libraryType, targets: ["AppKitBackend"]),
.library(name: "GtkBackend", type: libraryType, targets: ["GtkBackend"]),
.library(name: "Gtk3Backend", type: libraryType, targets: ["Gtk3Backend"]),
.library(name: "WinUIBackend", type: libraryType, targets: ["WinUIBackend"]),
.library(name: "DefaultBackend", type: libraryType, targets: ["DefaultBackend"]),
.library(name: "UIKitBackend", type: libraryType, targets: ["UIKitBackend"]),
.library(name: "Gtk", type: libraryType, targets: ["Gtk"]),
.library(name: "Gtk3", type: libraryType, targets: ["Gtk3"]),
.executable(name: "GtkExample", targets: ["GtkExample"]),
// .library(name: "CursesBackend", type: libraryType, targets: ["CursesBackend"]),
// .library(name: "QtBackend", type: libraryType, targets: ["QtBackend"]),
// .library(name: "LVGLBackend", type: libraryType, targets: ["LVGLBackend"]),
],
dependencies: [
.package(
url: "https://github.com/CoreOffice/XMLCoder",
from: "0.17.1"
),
.package(
url: "https://github.com/swiftlang/swift-docc-plugin",
from: "1.0.0"
Expand All @@ -98,18 +96,6 @@ let package = Package(
url: "https://github.com/stackotter/swift-image-formats",
.upToNextMinor(from: "0.3.2")
),
.package(
url: "https://github.com/stackotter/swift-windowsappsdk",
branch: "5caed8b4f1b4abc6fc89b8f0a8fa20f3edfab14a"
),
.package(
url: "https://github.com/thebrowsercompany/swift-windowsfoundation",
branch: "main"
),
.package(
url: "https://github.com/stackotter/swift-winui",
branch: "a81bc36e3ac056fbc740e9df30ff0d80af5ecd21"
),
// .package(
// url: "https://github.com/stackotter/TermKit",
// revision: "163afa64f1257a0c026cc83ed8bc47a5f8fc9704"
Expand Down Expand Up @@ -140,13 +126,6 @@ let package = Package(
"Scenes/TupleScene.swift.gyb",
]
),
.testTarget(
name: "SwiftCrossUITests",
dependencies: [
"SwiftCrossUI",
.target(name: "AppKitBackend", condition: .when(platforms: [.macOS])),
]
),
.target(
name: "DefaultBackend",
dependencies: [
Expand All @@ -163,7 +142,51 @@ let package = Package(
),
]
),
.target(name: "AppKitBackend", dependencies: ["SwiftCrossUI"]),
.macro(
name: "HotReloadingMacrosPlugin",
dependencies: [
.product(name: "SwiftSyntax", package: "swift-syntax"),
.product(name: "SwiftSyntaxMacros", package: "swift-syntax"),
.product(name: "SwiftCompilerPlugin", package: "swift-syntax"),
.product(name: "MacroToolkit", package: "swift-macro-toolkit"),
],
swiftSettings: swiftSettings
),

// .target(
// name: "CursesBackend",
// dependencies: ["SwiftCrossUI", "TermKit"]
// ),
// .target(
// name: "QtBackend",
// dependencies: ["SwiftCrossUI", .product(name: "Qlift", package: "qlift")]
// ),
// .target(
// name: "LVGLBackend",
// dependencies: [
// "SwiftCrossUI",
// .product(name: "LVGL", package: "LVGLSwift"),
// .product(name: "CLVGL", package: "LVGLSwift"),
// ]
// ),
]
)

if didFindGTK4 {
package.dependencies.append(contentsOf: [
.package(
url: "https://github.com/CoreOffice/XMLCoder",
from: "0.17.1"
)
])

package.products.append(contentsOf: [
.library(name: "Gtk", type: libraryType, targets: ["Gtk"]),
.library(name: "GtkBackend", type: libraryType, targets: ["GtkBackend"]),
.executable(name: "GtkExample", targets: ["GtkExample"]),
])

package.targets.append(contentsOf: [
.target(
name: "GtkBackend",
dependencies: ["SwiftCrossUI", "Gtk", "CGtk"]
Expand Down Expand Up @@ -198,9 +221,20 @@ let package = Package(
.executableTarget(
name: "GtkCodeGen",
dependencies: [
"XMLCoder", .product(name: "SwiftSyntaxBuilder", package: "swift-syntax"),
"XMLCoder",
.product(name: "SwiftSyntaxBuilder", package: "swift-syntax"),
]
),
])
}

if didFindGTK3 {
package.products.append(contentsOf: [
.library(name: "Gtk3", type: libraryType, targets: ["Gtk3"]),
.library(name: "Gtk3Backend", type: libraryType, targets: ["Gtk3Backend"]),
])

package.targets.append(contentsOf: [
.systemLibrary(
name: "CGtk3",
pkgConfig: "gtk+-3.0",
Expand All @@ -224,17 +258,49 @@ let package = Package(
name: "Gtk3CustomWidgets",
dependencies: ["CGtk3"]
),
.macro(
name: "HotReloadingMacrosPlugin",

])
}

#if os(macOS)
package.products.append(contentsOf: [
.library(name: "UIKitBackend", type: libraryType, targets: ["UIKitBackend"]),
.library(name: "AppKitBackend", type: libraryType, targets: ["AppKitBackend"]),
])

package.targets.append(contentsOf: [
.target(name: "AppKitBackend", dependencies: ["SwiftCrossUI"]),
.target(name: "UIKitBackend", dependencies: ["SwiftCrossUI"]),

.testTarget(
name: "SwiftCrossUITests",
dependencies: [
.product(name: "SwiftSyntax", package: "swift-syntax"),
.product(name: "SwiftSyntaxMacros", package: "swift-syntax"),
.product(name: "SwiftCompilerPlugin", package: "swift-syntax"),
.product(name: "MacroToolkit", package: "swift-macro-toolkit"),
],
swiftSettings: swiftSettings
"SwiftCrossUI",
.target(name: "AppKitBackend", condition: .when(platforms: [.macOS])),
]
),
.target(name: "UIKitBackend", dependencies: ["SwiftCrossUI"]),
])
#elseif os(Windows)
package.products.append(contentsOf: [
.library(name: "WinUIBackend", type: libraryType, targets: ["WinUIBackend"])
])

package.dependencies.append(contentsOf: [
.package(
url: "https://github.com/stackotter/swift-windowsappsdk",
branch: "5caed8b4f1b4abc6fc89b8f0a8fa20f3edfab14a"
),
.package(
url: "https://github.com/thebrowsercompany/swift-windowsfoundation",
branch: "main"
),
.package(
url: "https://github.com/stackotter/swift-winui",
branch: "a81bc36e3ac056fbc740e9df30ff0d80af5ecd21"
),
])

package.targets.append(contentsOf: [
.target(
name: "WinUIBackend",
dependencies: [
Expand All @@ -249,24 +315,25 @@ let package = Package(
name: "WinUIInterop",
dependencies: []
),
// .target(
// name: "CursesBackend",
// dependencies: ["SwiftCrossUI", "TermKit"]
// ),
// .target(
// name: "QtBackend",
// dependencies: ["SwiftCrossUI", .product(name: "Qlift", package: "qlift")]
// ),
// .target(
// name: "LVGLBackend",
// dependencies: [
// "SwiftCrossUI",
// .product(name: "LVGL", package: "LVGLSwift"),
// .product(name: "CLVGL", package: "LVGLSwift"),
// ]
// ),
]
)
.testTarget(
name: "SwiftCrossUITests",
dependencies: [
"SwiftCrossUI",
.target(name: "WinUIBackend", condition: .when(platforms: [.windows])),
]
),
])
#else
package.targets.append(contentsOf: [
.testTarget(
name: "SwiftCrossUITests",
dependencies: [
"SwiftCrossUI",
"DefaultBackend",
]
)
])
#endif

func getGtk4MinorVersion() -> Int? {
#if os(Windows)
Expand Down Expand Up @@ -310,3 +377,8 @@ func getGtk4MinorVersion() -> Int? {
}
return minor
}

func isGtk3Installed() -> Bool {
// FIXME: Stub
return false
}
0