-
-
Notifications
You must be signed in to change notification settings - Fork 46
Implement textContentType modifier #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Documentation is well written and the API is nice. Just a few tweaks and then I'm happy to merge.
@@ -38,6 +38,9 @@ public struct EnvironmentValues { | |||
/// The scale factor of the current window. | |||
public var windowScaleFactor: Double | |||
|
|||
/// The type of on-screen keyboard to show when a text field is focused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to mention that it still affects auto complete on some non-mobile platforms.
.name | ||
case .emailAddress: | ||
.emailAddress | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch over remaining cases so that we're forced to evaluate how to handle new text content types when we add them in future (same goes for other backend implementations).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same goes for other backend implementations
I'm updating AppKit now, but GTK doesn't use textContentType at all, and UIKit and WinUI don't have default:
branches. Could you clarify what you meant by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time I left that comment I hadn't read through the other backends yet, so I just added that as a catch all. Only happens to apply to AppKitBackend though, so ignore that
No description provided.