feat(useDialog): add support for useDialog #4300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add warning message when useToaster is used without a CustomProvider - Add test case to verify the warning behavior
- Added descriptive text for each example in both Chinese and English - Included notes about useToaster requiring CustomProvider - Improved documentation clarity for Message, Notification, and Toaster components
- Implemented useDialog hook for managing dialog state - Added Dialog and DialogContainer components - Added documentation in both English and Chinese - Added translations for Dialog component in all supported languages - Added unit tests for the new functionality
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4300 +/- ##
==========================================
+ Coverage 94.27% 94.30% +0.02%
==========================================
Files 543 546 +3
Lines 13266 13390 +124
Branches 3954 3985 +31
==========================================
+ Hits 12507 12627 +120
- Misses 691 695 +4
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Removed showCancelButton prop from Dialog component and related types - Added internal logic to show cancel button based on dialog type (confirm/prompt) - Updated tests to remove showCancelButton prop usage - Simplified dialog creation in useDialog hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
useDialogReact Hook and updates documentation across multiple components to improve clarity and usability. The changes include adding 8000 comprehensive documentation foruseDialog, enhancing existing component documentation, and integrating theDialogContainerinto theCustomProviderfor dialog management.