8000 fix(useToaster): add warning when used outside of CustomProvider by simonguo · Pull Request #4296 · rsuite/rsuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(useToaster): add warning when used outside of CustomProvider #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

simonguo
Copy link
Member
  • Add warning message when useToaster is used without a CustomProvider
  • Add test case to verify the warning behavior

- Add warning message when useToaster is used without a CustomProvider
- Add test case to verify the warning behavior
Copy link
codesandbox bot commented May 23, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2025 3:56pm
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2025 3:56pm

Copy link
codesandbox-ci bot commented May 23, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.27%. Comparing base (d5d9915) to head (50cabeb).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4296   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files         543      543           
  Lines       13266    13269    +3     
  Branches     3954     3955    +1     
=======================================
+ Hits        12507    12510    +3     
  Misses        691      691           
  Partials       68       68           
Flag Coverage Δ
chromium 94.27% <100.00%> (+<0.01%) ⬆️
firefox 94.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Added descriptive text for each example in both Chinese and English
- Included notes about useToaster requiring CustomProvider
- Improved documentation clarity for Message, Notification, and Toaster components
@simonguo simonguo merged commit 853d81b into next May 26, 2025
16 of 17 checks passed
@simonguo simonguo deleted the fix/use-toaster-warning branch May 26, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0