8000 fix(vite): resolve circular dependency between chunks by simonguo · Pull Request #4246 · rsuite/rsuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(vite): resolve circular dependency between chunks #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025

Conversation

simonguo
Copy link
Member

fix: #4168

@simonguo simonguo requested a review from Copilot April 18, 2025 06:52
Copy link
codesandbox bot commented Apr 18, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 7:02am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 7:02am

Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses circular dependency issues by updating various import paths and re-organizing exports in the CustomProvider module. Key changes include:

  • Changing import paths for CustomContext from deep relative paths to a consolidated one.
  • Updating hook imports to use the alias "@/internals/hooks" across multiple files.
  • Adjusting export references in the CustomProvider index and related modules.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/useToaster/useToaster.ts Updated CustomContext import path
src/internals/hooks/useClassNames.ts Updated CustomContext import path
src/internals/Picker/* files Updated hook import paths to use alias "@/internals/hooks"
src/Image/hooks/useImage.ts Adjusted import for useIsomorphicLayoutEffect
src/CustomProvider/* files Updated imports/exports for CustomContext and useCustom
src/CustomProvider/CustomProvider.tsx Applied type cast change for ref in toaster mapping

Copy link
codesandbox-ci bot commented Apr 18, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (4697f22) to head (b5c5307).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4246   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files         524      525    +1     
  Lines       12509    12509           
  Branches     3206     3206           
=======================================
  Hits        11156    11156           
  Misses        677      677           
  Partials      676      676           
Flag Coverage Δ
ChromeCi 89.12% <100.00%> (ø)
Firefox 89.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simonguo simonguo merged commit 9dca238 into main Apr 18, 2025
16 checks passed
@simonguo simonguo deleted the fix/build-rollup-modules branch April 18, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0