-
-
Notifications
You must be signed in to change notification settings - Fork 955
fix(vite): resolve circular dependency between chunks #4246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses circular dependency issues by updating various import paths and re-organizing exports in the CustomProvider module. Key changes include:
- Changing import paths for CustomContext from deep relative paths to a consolidated one.
- Updating hook imports to use the alias "@/internals/hooks" across multiple files.
- Adjusting export references in the CustomProvider index and related modules.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/useToaster/useToaster.ts | Updated CustomContext import path |
src/internals/hooks/useClassNames.ts | Updated CustomContext import path |
src/internals/Picker/* files | Updated hook import paths to use alias "@/internals/hooks" |
src/Image/hooks/useImage.ts | Adjusted import for useIsomorphicLayoutEffect |
src/CustomProvider/* files | Updated imports/exports for CustomContext and useCustom |
src/CustomProvider/CustomProvider.tsx | Applied type cast change for ref in toaster mapping |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 524 525 +1
Lines 12509 12509
Branches 3206 3206
=======================================
Hits 11156 11156
Misses 677 677
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix: #4168