8000 build(deps): bump eslint from 7.25.0 to 9.17.0 by simonguo · Pull Request #4092 · rsuite/rsuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build(deps): bump eslint from 7.25.0 to 9.17.0 #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

simonguo
Copy link
Member

This pull request includes significant updates to the ESLint configuration and various codebase improvements. The most important changes include the removal of the old ESLint configuration, the addition of a new ESLint configuration file, updates to the package.json dependencies, and the removal of unnecessary ESLint disable comments.

ESLint Configuration Updates:

Package Updates:

Codebase Simplification:

  • docs/components/PageContent.tsx: Removed unnecessary ESLint disable comments and simplified regex patterns. [1] [2] [3] [4]
  • src/Accordion/Accordion.tsx, src/AutoComplete/Combobox.tsx, src/Breadcrumb/Breadcrumb.tsx, src/Card/Card.tsx: Refactored React forwardRef functions for better readability. [1] [2] [3] [4]

Testing Improvements:

Script Adjustments:

  • package.json: Updated the lint script to remove the separate linting for JavaScript files, now covered by the TypeScript linting.

Copy link
codesandbox bot commented Dec 26, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 11:09am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 11:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 11:09am

Copy link
codesandbox-ci bot commented Dec 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 89.46237% with 49 lines in your changes missing coverage. Please review.

Project coverage is 89.30%. Comparing base (4c0efdb) to head (13b3ab0).
Report is 1 commits behind head on next.

Files with missing lines Patch % Lines
src/DateRangePicker/DateRangePicker.tsx 88.76% 12 Missing and 19 partials ⚠️
src/Modal/Modal.tsx 88.73% 3 Missing and 5 partials ⚠️
src/Nav/NavDropdown.tsx 81.25% 3 Missing and 3 partials ⚠️
src/DatePicker/PredefinedRanges.tsx 88.88% 1 Missing and 1 partial ⚠️
src/RangeSlider/RangeSlider.tsx 50.00% 0 Missing and 1 partial ⚠️
src/Tabs/Tabs.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4092      +/-   ##
==========================================
- Coverage   89.30%   89.30%   -0.01%     
==========================================
  Files         517      517              
  Lines       12206    12213       +7     
  Branches     3164     3164              
==========================================
+ Hits        10901    10907       +6     
+ Misses        641      640       -1     
- Partials      664      666       +2     
Flag Coverage Δ
ChromeCi 75.86% <89.24%> (+<0.01%) ⬆️
Firefox 89.28% <89.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo added this to the v6 milestone Dec 26, 2024
@simonguo simonguo merged commit 3449dc3 into next Dec 27, 2024
15 of 17 checks passed
@simonguo simonguo deleted the build/eslint-9 branch December 27, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0