refactor: remove deprecated Less variables #4080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4080 +/- ##
==========================================
+ Coverage 89.24% 89.30% +0.05%
==========================================
Files 517 517
Lines 12186 12186
Branches 3162 3162
==========================================
+ Hits 10876 10883 +7
+ Misses 646 641 -5
+ Partials 664 662 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the consistency and maintainability of the LESS stylesheets. The most important changes involve the introduction of a new mixin for mapping sizes, replacing deprecated variables, and updating import paths.
Introduction of new mixin:
src/styles/mixins/utilities.less: Added.map-sizemixin to map size names to suffixes, which helps in standardizing size-related variables.Replacement of deprecated variables:
src/styles/variables.less: Removed deprecated variables and replaced them with their new equivalents, such as@padding-base-verticalwith@padding-y,@padding-large-verticalwith@padding-y-lg, and others. [1] [2] [3] [4] [5] [6] [7] [8] [9]Updates to import paths:
src/SelectPicker/styles/index.less: Changed the import path of the Picker styles to include the.lessextension for consistency.Usage of new mixin in existing styles:
src/Form/styles/mixin.less: Updated the.reset-input-group-addon-sizeand.reset-inside-input-group-btn-sizemixins to use the new.map-sizemixin for padding variables. [1] [2]src/internals/Picker/styles/index.less: Replaced deprecated size-related mixins with the new.picker-button-sizemixin. [1] [2]src/internals/Picker/styles/mixin.less: Added.map-sizemixin to.picker-button-sizeand.picker-default-button-reset-padding-leftfor padding variables. [1] [2]