8000 Allow specifying multiple -e (--example) options by dblock · Pull Request #614 · rspec/rspec-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Allow specifying multiple -e (--example) options #614

Merged
merged 2 commits into from
May 13, 2012

Conversation

dblock
Copy link
Contributor
@dblock dblock commented May 4, 2012

Ported support for multiple -e options from #596. You can specify -l multiple times, there's no reason why -e isn't cumulative.

@travisbot
Copy link

This pull request passes (merged 2f88804 into 95bf11b).

filter_run :full_description => Regexp.union(description.map { |d| /#{d}/ })
else
filter_run :full_description => /#{description}/
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to get rid of the conditional:

filter_run :full_description => Regexp.union(*Array(description).map {|d| Regexp.new(d) })

Works on MRI 1.8 and 1.9 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change, it's much prettier. Updated the pull request.
cc: @dchelimsky

@travisbot
Copy link

This pull request passes (merged dc33f77 into 95bf11b).

@dchelimsky
Copy link
Contributor

@travisbot is AWESOME!!!!!!!!!!!!

justinko added a commit that referenced this pull request May 13, 2012
Allow specifying multiple -e (--example) options
@justinko justinko merged commit 22e689c into rspec:master May 13, 2012
@AnneTheAgile
Copy link

This ticket should be closed because the fix was merged in, right?

@myronmarston
Copy link
Member

This has been closed:

screen shot 2014-11-12 at 8 16 41 am

Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0