feat: cleartext framework support #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hko-s
reviewed
Apr 3, 2024
| Signature(StandaloneSignature), | ||
| } | ||
|
|
||
| impl Any { |
There was a problem hiding this comment.
This name clashes with std::any::Any. I wonder if the name is worth changing.
I fear the RFC doesn't offer terminology for "any kind of PGP thing". The most generic objects it names are "Messages" and "Keys" (neither of which includes cleartext messages).
Attempting to brainstorm alternative names: (Open)PgpData, (Open)PgpContent.
I currently have no idea that I'm excited about.
(I don't think this kind of generic reader needs to be limited to armored data, so I would tend to not use "armor" in the naming)
There was a problem hiding this comment.
I think I am going to stick with Any for now, and wait for better suggestions :)
828da68 to
fb5a09c
Compare
* csf: add test * csf O_o * xx: this should not not fail * anything but whitespace is not ok after the armor footer * use expect in signed_text
fb5a09c to
11ff3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to @hko-s for tips and existing work.
composed::CleartextSignedMessagecomposed::Anyfor dealing with arbitrary armor based contentCloses #122