add caddy support #411
Draft
add caddy support #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aidaho12
reviewed
Jan 23, 2025
| @@ -156,6 +165,7 @@ def default_values(): | |||
| {'service_id': 4, 'service': 'Apache', 'slug': 'apache'}, | |||
| {'service_id': 5, 'service': 'HA cluster', 'slug': 'cluster'}, | |||
| {'service_id': 6, 'service': 'UDP listener', 'slug': 'udp'}, | |||
| {'service_id': 2, 'service': 'Caddy', 'slug': 'caddy'}, | |||
There was a problem hiding this comment.
service_id must be 7, 2 is for nginx
|
|
||
| kwargs = { | ||
| 'haproxy': haproxy, | ||
| 'nginx': nginx, | ||
| 'apache': apache, | ||
| 'ip': vip, | ||
| 'caddy': caddy, |
There was a problem hiding this comment.
if you would like do caddy installation with creating HA cluster, you should write ansible role for it
| @@ -12,7 +12,7 @@ def generate_exporter_inc(server_ip: str, ver: str, exporter: str) -> object: | |||
| 'service': f'{exporter} exporter' | |||
| } | |||
|
|
|||
| if exporter in ('haproxy', 'nginx', 'apache'): | |||
| if exporter in ('haproxy', 'nginx', 'apache', 'caddy'): | |||
There was a problem hiding this comment.
if you would like do caddy exporter installation, you should write ansible role for it
There was a problem hiding this comment.
Does caddy have the same stats page as haproxy?
| @@ -22,6 +22,7 @@ | |||
| <script src="/static/js/codemirror/addon/fold/comment-fold.js"></script> | |||
| <script src="/static/js/codemirror/addon/scroll/annotatescrollbar.js"></script> | |||
| <script src="/static/js/codemirror/mode/nginx.js"></script> | |||
| <script src="/static/js/codemirror/mode/caddy.js"></script> | |||
| <span class="ui-button ui-widget ui-corner-all" id="caddy_install" title="{{lang.words.install|title()}} Caddy">{{lang.words.install|title()}}</span> | ||
| </td> | ||
| </tr> | ||
| </table> |
There was a problem hiding this comment.
if you would like do caddy installation, you should write ansible role for it
|
Looks great, but there are some comments from me. Also will be great if you create update DB for caddy in the create_db.py file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is done by copying what's done for the counterparts, but I'm having a hard time testing the changes due to #407.
Resolves #336
Keeping the PR as draft until sanity checks are done and is validated.