8000 feat: add filtering capability to manual balances by kelsos · Pull Request #8038 · rotki/rotki · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filtering capability to manual balances #8038

Merged
merged 3 commits into from
Jun 10, 2024
Merged

feat: add filtering capability to manual balances #8038

merged 3 commits into from
Jun 10, 2024

Conversation

kelsos
Copy link
Member
@kelsos kelsos commented Jun 6, 2024 •
edited
Loading

Closes #7974

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

TODO

  • Make sure adding and editing work fine after changes
  • Test combined filtering
  • See why total is off

@codecov Codecov
Copy link
codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.30572% with 328 lines in your changes missing coverage. Please review.

Project coverage is 53.53%. Comparing base (92c06bf) to head (ddf02a5).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ts/accounts/manual-balances/ManualBalanceTable.vue 0.00% 91 Missing ⚠️
frontend/app/src/pages/balances/manual/index.vue 0.00% 79 Missing ⚠️
...ts/accounts/manual-balances/ManualBalancesForm.vue 0.00% 53 Missing ⚠️
...end/app/src/composables/filters/manual-balances.ts 24.24% 50 Missing ⚠️
...d/app/src/utils/balances/manual/manual-balances.ts 70.73% 36 Missing ⚠️
frontend/app/src/store/balances/manual.ts 77.14% 16 Missing ⚠️
...p/src/components/accounts/blockchain/XpubInput.vue 0.00% 1 Missing ⚠️
...accounts/management/types/ValidatorAccountForm.vue 0.00% 1 Missing ⚠️
...rontend/app/src/components/helper/PriceRefresh.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #8038       +/-   ##
============================================
- Coverage    80.51%   53.53%   -26.98%     
============================================
  Files         1226     1682      +456     
  Lines       108691   167265    +58574     
  Branches     13162    13693      +531     
============================================
+ Hits         87512    89549     +2037     
- Misses       18853    75390    +56537     
  Partials      2326     2326
Flag Coverage Δ
frontend_integration 59.60% <74.25%> (+0.09%) ⬆️
frontend_unit 38.67% <29.19%> (-40.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos force-pushed the manual-balance-filter branch from 4927790 to 71eb881 Compare June 7, 2024 17:17
@kelsos kelsos marked this pull request as ready for review June 7, 2024 17:19
@kelsos kelsos force-pushed the manual-balance-filter branch 2 times, most recently from 076c93f to c9f2c80 Compare June 10, 2024 10:43
@kelsos kelsos requested a review from lukicenturi June 10, 2024 10:46
lukicenturi
lukicenturi approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor
@lukicenturi lukicenturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kelsos kelsos force-pushed the manual-balance-filter branch from ddf02a5 to 39e7c49 Compare June 10, 2024 13:47
@kelsos kelsos merged commit a50697f into rotki:develop Jun 10, 2024
15 checks passed
@kelsos kelsos deleted the manual-balance-filter branch June 10, 2024 13:56
@kelsos kelsos temporarily deployed to cassette-merge June 10, 2024 13:56 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukicenturi lukicenturi lukicenturi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce table filter for location, label, asset in the manual balances table
2 participants
@kelsos @lukicenturi
0