8000 Include a link to transactions on the "issues found with generated report" screen · Issue #8690 · rotki/rotki · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a link to transactions on the "issues found with generated report" screen #8690

Closed
TimTinkers opened this issue Oct 8, 2024 · 5 comments · Fixed by #8824
Closed

Comments

@TimTinkers
Copy link

Abstract

Hello, I am a first-time Rotki user attempting to get it accurately tracking my portfolio so I can do taxes. I've years and years of cruft to get sorted first so naturally, when I went to generate a tax report, I have many issues that I need to manually resolve. In this screen there is a Date/Time reference for presumably when I received the asset with the missing price, but it would also be very nice to have a link to the transaction being referenced for that time as well.

2024-10-07-223338_980x330_scrot

Motivation

Having a convenient link to the block explorer for these transactions would make it much easier for the user to remember what they were doing and may make it easier to figure out the price they should input, particularly if they were swapping stablecoins for the asset in question.

Specification

Presumably the Date/Time of the asset is being pulled from the time of a particular transaction and Rotki could insert the link here, like it does on the "newly detected tokens" screen.

@TimTinkers
Copy link
Author

Also not to muddy the waters on this feature request (I'd be happy to open another issue once I confirm it's not something wrong on my end) but this is especially needed for me because the Rotki price detection in resolving these missing prices seems to not be working and getting rate-limited 100% of the time on anything that is not Ether (including some very popular DeFi coins that should be definitely retrievable). I will look for logs to confirm what might be happening there tomorrow.

@LefterisJP
Copy link
Member

In this screen there is a Date/Time reference for presumably when I received the asset with the missing price, but it would also be very nice to have a link to the transaction being referenced for that time as well.

This screen has 2 possibilities.

  1. Missing acquisition, in which case it's an event that sees you try to spend something you don't have. So we need you to tell us where that something was acquired and at what price
  2. Missing price for an event. Means rotki can't query it in any of the given oracles. (rate limiting is also possible as you said)

Adding a link here should be possible technically. Let us think a bit and we may be able to improve here. Thanks!

@TimTinkers
Copy link
Author

Thanks! I also dug into the rate limiting issue further and found it was due to missing CryptoCompare information, #8696.

@kelsos
Copy link
Member
kelsos commented Oct 25, 2024

@lukicenturi do you remember what is needed for this to be implemented?

LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Oct 26, 2024
This commit adds the identifier of the history event at which we have
encountered a missing acquisition as originating_event_id.

It's optional and may be missing, since not all events are history
events at the moment.

Part of rotki#8690

Signed-off-by: Lefteris Karapetsas <lefteris@refu.co>
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Oct 26, 2024
This commit adds the identifier of the history event at which we have
encountered a missing acquisition as originating_event_id.

It's optional and may be missing, since not all events are history
events at the moment.

Part of rotki#8690

Signed-off-by: Lefteris Karapetsas <lefteris@refu.co>
LefterisJP added a commit that referenced this issue Oct 26, 2024
This commit adds the identifier of the history event at which we have
encountered a missing acquisition as originating_event_id.

It's optional and may be missing, since not all events are history
events at the moment.

Part of #8690

Signed-off-by: Lefteris Karapetsas <lefteris@refu.co>
@LefterisJP
Copy link
Member

Made it so the backend also returns the originating event identifier, if existing, for any missing acquisition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@LefterisJP @kelsos @TimTinkers and others
0