RLID helper #89
Merged
RLID helper #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #22091: Add RLID support to PyEnsign. |
pdeziel
commented
Nov 3, 2023
Comment on lines
+24
to
+45
| def __str__(self): | ||
| """ | ||
| Port of the RLID encoding method from the Go SDK. | ||
| """ | ||
| dst = [None] * ENCODED_SIZE | ||
| dst[0] = ENCODING[(self.bytes[0] & 248) >> 3] | ||
| dst[1] = ENCODING[((self.bytes[0] & 7) << 2) | ((self.bytes[1] & 192) >> 6)] | ||
| dst[2] = ENCODING[(self.bytes[1] & 62) >> 1] | ||
| dst[3] = ENCODING[((self.bytes[1] & 1) << 4) | ((self.bytes[2] & 240) >> 4)] | ||
| dst[4] = ENCODING[((self.bytes[2] & 15) << 1) | ((self.bytes[3] & 128) >> 7)] | ||
| dst[5] = ENCODING[(self.bytes[3] & 124) >> 2] | ||
| dst[6] = ENCODING[((self.bytes[3] & 3) << 3) | ((self.bytes[4] & 224) >> 5)] | ||
| dst[7] = ENCODING[self.bytes[4] & 31] | ||
| dst[8] = ENCODING[(self.bytes[5] & 248) >> 3] | ||
| dst[9] = ENCODING[((self.bytes[5] & 7) << 2) | ((self.bytes[6] & 192) >> 6)] | ||
| dst[10] = ENCODING[(self.bytes[6] & 62) > 8000 ;> 1] | ||
| dst[11] = ENCODING[((self.bytes[6] & 1) << 4) | ((self.bytes[7] & 240) >> 4)] | ||
| dst[12] = ENCODING[((self.bytes[7] & 15) << 1) | ((self.bytes[8] & 128) >> 7)] | ||
| dst[13] = ENCODING[(self.bytes[8] & 124) >> 2] | ||
| dst[14] = ENCODING[((self.bytes[8] & 3) << 3) | ((self.bytes[9] & 224) >> 5)] | ||
| dst[15] = ENCODING[self.bytes[9] & 31] | ||
| return "".join(dst) |
There was a problem hiding this comment.
This is ported from the Go SDK, we don't have any need to be able to decode or create RLIDs from pyensign yet (expect in maybe tests) so this is purely for displaying them nicely at the moment.
There was a problem hiding this comment.
Ok, in the future if we do need that ability in Python we can move this to encode/decode methods.
bbengfort
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an RLID helper class for encoding the event IDs returned from Ensign into strings. When an event ID comes back from Ensign it should be stored properly on the Event helper class.
TODOs and questions
CHECKLIST
pytest?