8000 Stream handler unit tests by pdeziel · Pull Request #48 · rotationalio/pyensign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stream handler unit tests #48

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2023
Merged

Stream handler unit tests #48

merged 4 commits into from
Jul 12, 2023

Conversation

pdeziel
Copy link
Collaborator
@pdeziel pdeziel commented Jun 28, 2023

This PR adds some test coverage for the stream handler methods.

I have made the following changes:

  1. Add tests for StreamHandler, Publisher, and Subscriber
  2. Lower reconnect tick in connection tests so that tests run faster

TODOs and questions

CHECKLIST

  • Is the commit message formatted correctly?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #17915: Add unit tests for stream.py.

@pdamodaran pdamodaran self-requested a review June 29, 2023 15:10
pdamodaran
pdamodaran approved these changes Jul 12, 2023
View reviewed changes
Copy link
@pdamodaran pdamodaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @pdeziel! I just had one question: I noticed that you have added kwargs to the stream handlers, was that done to add more functionality in the future?

@pdeziel
Copy link
Collaborator Author
pdeziel commented Jul 12, 2023

looks good @pdeziel! I just had one question: I noticed that you have added kwargs to the stream handlers, was that done to add more functionality in the future?

I think I added that in order to pass through the reconnect_tick and reconnect_timeout so I didn't have to redefine them, but also there may be more configuration in the future that's shared between Publisher and Subscriber since they are both stream handlers.

@pdeziel pdeziel merged commit 764f039 into develop Jul 12, 2023
@pdeziel pdeziel deleted the sc-17915 branch July 12, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdamodaran pdamodaran pdamodaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdeziel @pdamodaran
0