8000 Deprecate use of requests package by pdeziel · Pull Request #33 · rotationalio/pyensign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecate use of requests package #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2023
Merged

Deprecate use of requests package #33

merged 2 commits into from
Jun 12, 2023

Conversation

pdeziel
Copy link
Collaborator
@pdeziel pdeziel commented Jun 12, 2023

This PR addresses a compatibility issue with use of the requests package. This issue discusses urllib3 dropping support for OpenSSL < 1.1.1. PyEnsign doesn't use HTTPs, but it does have to make HTTP requests to retrieve credentials on behalf the user. We want to support Python < 3.10 even if users have older versions of OpenSSL installed so this PR implements the HTTP requests using the builtin urllib instead.

I have made the following changes:

  1. Remove requests and urllib3 from requirements.txt
  2. Implemented HTTP requests with urllib instead of urllib3

TODOs and questions

CHECKLIST

  • Is the commit message formatted correctly?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #17647: urllib3 compatibility error.

@pdeziel pdeziel requested a review from pdamodaran June 12, 2023 14:45
pdamodaran
pdamodaran approved these changes Jun 12, 2023
View reviewed changes
Copy link
@pdamodaran pdamodaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - @pdeziel!

@pdeziel pdeziel merged commit 7abc7aa into develop Jun 12, 2023
@pdeziel pdeziel deleted the sc-17647 branch June 12, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5D02
Reviewers

@pdamodaran pdamodaran pdamodaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdeziel @pdamodaran
0