8000 [Compression - 7] Add compression metadata by piraka9011 · Pull Request #221 · ros2/rosbag2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compression - 7] Add compression metadata #221

Merged
merged 5 commits into from
Jan 6, 2020
Merged

[Compression - 7] Add compression metadata #221

merged 5 commits into from
Jan 6, 2020

Conversation

piraka9011
Copy link
Contributor
@piraka9011 piraka9011 commented Nov 27, 2019 •
edited by zmichaels11
Loading

Changes

  • Bump metadata version (2 -> 3)
  • Adds fields:
    • compression_format
    • compression_mode
  • Update tests to account for new metadata info
  • metadata version 2 is still supported
    • Add unit test to verify metadata with version 2 can still be read.

@piraka9011 piraka9011 changed the title [Compression - 6] Add compression metadata [Compression - 7] Add compression metadata Dec 12, 2019
@zmichaels11 zmichaels11 mentioned this pull request Dec 19, 2019
Closed
@zmichaels11
Add compression options to metadata, update tests
4f229e2 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
@zmichaels11 zmichaels11 force-pushed the compression/metadata branch from da8dce6 to 1135196 Compare January 3, 2020 16:22
@zmichaels11
Add check for metadata version in metadata_io
124be54 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 force-pushed the compression/metadata branch from 8ff57ce to 1f72513 Compare January 3, 2020 16:26
@zmichaels11
Add new line to end of file
1a6a730 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 force-pushed the compression/metadata branch from 1f72513 to 1a6a730 Compare January 3, 2020 16:27
@zmichaels11
Fix linting and renamed compression_mode from bagfile to file
0ea384f 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Rename compression_mode from "file" to "FILE"
735560e 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 marked this pull request as ready for review January 3, 2020 17:39
@zmichaels11
Copy link
Contributor

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/071d3dfa2ab96193b88add6db952218a/raw/d79e3aea2a41516610cada96ba65eb2dca99b076/ros2.repos
BUILD args: --packages-up-to rosbag2 rosbag2_storage rosbag2_storage_default_plugins rosbag2_tests
TEST args: --packages-select rosbag2 rosbag2_storage rosbag2_storage_default_plugins rosbag2_tests
Job: ci_launcher

@dabonnie
Copy link
Contributor
dabonnie commented Jan 3, 2020 •
edited
Loading

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/071d3dfa2ab96193b88add6db952218a/raw/d79e3aea2a41516610cada96ba65eb2dca99b076/ros2.repos
BUILD args: --packages-up-to rosbag2 rosbag2_storage rosbag2_storage_default_plugins rosbag2_tests
TEST args: --packages-select rosbag2 rosbag2_storage rosbag2_storage_default_plugins rosbag2_tests
Job: ci_launcher

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11
Copy link
Contributor
zmichaels11 commented Jan 6, 2020 •
edited by piraka9011
Loading

It looks like Windows failed due to buildfarm issues.

  • Windows Build Status

Karsten1987
Karsten1987 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Collaborator
@Karsten1987 Karsten1987 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

emersonknapp
emersonknapp approved these changes Jan 6, 2020
View reviewed changes
Copy link
Collaborator
@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also lgtm

@piraka9011
Copy link
Contributor Author
piraka9011 commented Jan 6, 2020 •
edited
Loading

@Karsten1987 The windows build farm has been flakey (Pinging @nuclearsandwich), so we compiled and tested on our bare metal windows machine successfully.

I'm running one more CI but propose to merge if it fails again.

  • Windows Build Status

@piraka9011 piraka9011 merged commit e02bc77 into ros2:master Jan 6, 2020
@zmichaels11 zmichaels11 deleted the compression/metadata branch January 6, 2020 21:01
@piraka9011 piraka9011 mentioned this pull request Jan 11, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@prajakta-gokhale prajakta-gokhale Awaiting requested review from prajakta-gokhale

@dabonnie dabonnie Awaiting requested review from dabonnie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@piraka9011 @zmichaels11 @dabonnie @emersonknapp @Karsten1987
0