[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend timeout to shutdown the command line process. #783

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Extend timeout to shutdown the command line process. #783

merged 1 commit into from
Dec 14, 2022

Conversation

fujitatomoya
Copy link
Collaborator

address flaky test: #772

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

@fujitatomoya
Extend timeout to shutdown the command line process.
0d8486c 
  address flaky test: #772

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@Blast545 @Crola1702 friendly ping

CC: @llapx

@Crola1702 Crola1702 self-requested a review December 13, 2022 19:25
Crola1702
Crola1702 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor
@Crola1702 Crola1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Blast545
Blast545 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor
@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya commented Dec 13, 2022
View reviewed changes
Copy link
Collaborator Author
@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review, i will merge this with green CI.

@fujitatomoya fujitatomoya merged commit 615efe6 into rolling Dec 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/20221213-extend-timeout-to-shutdown branch December 14, 2022 18:50
@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport humble

@mergify mergify bot mentioned this pull request Dec 14, 2022
Merged
@mergify
Copy link
mergify bot commented Dec 14, 2022

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 14, 2022
@fujitatomoya @mergify
Extend timeout to shutdown the command line process. (#783)
d3243e8 
  address flaky test: #772

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 615efe6)
fujitatomoya added a commit that referenced this pull request Dec 15, 2022
@mergify @fujitatomoya
Extend timeout to shutdown the command line process. (#783) (#784)
2309182 
address flaky test: #772

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 615efe6)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crola1702 Crola1702 Crola1702 approved these changes

@Blast545 Blast545 Blast545 approved these changes

@audrow audrow Awaiting requested review from audrow

@gbiggs gbiggs Awaiting requested review from gbiggs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @Blast545 @Crola1702