[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test on ros2topic: test_use_sim_time.TestROS2TopicUseSimTime.test_pub_times #772

Closed
Crola1702 opened this issue Oct 17, 2022 · 6 comments
Assignees

Comments

@Crola1702
Copy link
Contributor

Bug report

Required Info:

  • Operating System:
    • Ubuntu 22.04 (Jammy)
  • Installation type:
    • Source
  • Version or commit hash:
    • Rolling
  • DDS implementation:
    • All

Steps to reproduce issue

  1. Wait for Ros2 ci nightlies to run
  2. See test failure (Reference build here)

Expected behavior

Pass on all builds

Actual behavior

Failing in some builds (percentages for the last 2 weeks):

Log output:

FAIL: test_use_sim_time.TestROS2TopicUseSimTime.test_pub_times
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins-agent/workspace/nightly_linux_debug/ws/install/launch_testing/lib/python3.10/site-packages/launch_testing/markers.py", line 57, in _wrapper
    return func(self, *args, **kwargs)
  File "/home/jenkins-agent/workspace/nightly_linux_debug/ws/src/ros2/ros2cli/ros2topic/test/test_use_sim_time.py", line 124, in test_pub_times
    assert command.wait_for_shutdown(timeout=1)
AssertionError: assert False
 +  where False = <bound method ProcessProxy.wait_for_shutdown of <launch_testing.tools.process.ProcessProxy object at 0x7f5f3fac0d60>>(timeout=1)
 +    where <bound method ProcessProxy.wait_for_shutdown of <launch_testing.tools.process.ProcessProxy object at 0x7f5f3fac0d60>> = <launch_testing.tools.process.ProcessProxy object at 0x7f5f3fac0d60>.wait_for_shutdown

Additional information

First failing build (for linux): https://ci.ros2.org/view/nightly/job/nightly_linux_repeated/2802/
First failing build (for rhel): https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_debug/1279/

@Blast545
Copy link
Contributor

Using scripting database tools, the first time it appeared in Rolling debug (30 days ago)

https://build.ros2.org/view/Rci/job/Rci__nightly-release_ubuntu_jammy_amd64/207/
https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_debug/1268/

@Crola1702
Copy link
Contributor Author

It happened today in rolling Debug build: Rolling nightly 242

@Crola1702
Copy link
Contributor Author

It happened today in Linux Debug build: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/

@Crola1702
Copy link
Contributor Author

It happened today in Linux Release build: https://ci.ros2.org/view/nightly/job/nightly_linux_release/2459/

@mjcarroll mjcarroll self-assigned this Nov 9, 2022
@Blast545
Copy link
Contributor
Blast545 commented Dec 9, 2022

This error was added with this PR: #754

fujitatomoya added a commit that referenced this issue Dec 13, 2022
  address flaky test: #772

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this issue Dec 14, 2022
  address flaky test: #772

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
mergify bot pushed a commit that referenced this issue Dec 14, 2022
  address flaky test: #772

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 615efe6)
fujitatomoya added a commit that referenced this issue Dec 15, 2022
address flaky test: #772

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 615efe6)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator

this flaky test has been addressed for humble and foxy, i will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants