[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter values get evaluated by yaml rules #31

Merged
merged 3 commits into from
May 21, 2019
Merged

Parameter values get evaluated by yaml rules #31

merged 3 commits into from
May 21, 2019

Conversation

sloretz
Copy link
Contributor
@sloretz sloretz commented May 20, 2019

Resolves #30

This PR evaluates parameter values as yaml would.

I'm not set up to run mypy at the moment, so I'm not confident the type annotations are correct.

@sloretz
parameter values get evaluated by yaml rules
facb186 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested review from wjwwood and Karsten1987 May 20, 2019 23:46
@sloretz sloretz self-assigned this May 20, 2019
wjwwood
wjwwood approved these changes May 21, 2019
View reviewed changes
Copy link
Member
@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but overall lgtm!

launch_ros/launch_ros/utilities/evaluate_parameters.py Outdated Show resolved Hide resolved
launch_ros/launch_ros/utilities/evaluate_parameters.py Outdated Show resolved Hide resolved
launch_ros/launch_ros/utilities/evaluate_parameters.py Show resolved Hide resolved
sloretz added 2 commits May 21, 2019 09:42
@sloretz
Use new variable type syntax
379e43f 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
type_ -> last_subtype
032ae59 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor Author
sloretz commented May 21, 2019

CI (testing launch_ros and test_launch_ros)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit bb82f31 into master May 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the sloretz/yamlfy_parameter_values branch May 21, 2019 17:28
@Karsten1987
Copy link
Contributor

Oh, too late for the party. But anyway, this works great! :)

One can now set boolean parameters when launching a node:

        Node(
            package='robot_state_publisher',
            node_executable='robot_state_publisher',
            node_name='robot_state_publisher',
            output='screen',
            parameters=[{'use_sim_time': LaunchConfiguration('use_sim_time')}],
            arguments=[urdf])

This was referenced Jun 3, 2019
Merged
Merged
@ivanpauno ivanpauno mentioned this pull request Jul 3, 2019
Merged
@hidmic hidmic mentioned this pull request Sep 19, 2019
Closed
@ivanpauno ivanpauno mentioned this pull request Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

Assignees

@sloretz sloretz

Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

launch file should interpret LaunchConfiguration values as yaml
3 participants
@sloretz @Karsten1987 @wjwwood