8000 fix: return text value to avoid exception (#338) by wep21 · Pull Request #340 · ros2/launch_ros · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return text value to avoid exception (#338) #340

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

wep21
Copy link
Contributor
@wep21 wep21 commented Dec 8, 2022

I think #338 is a bug fix, so I would like to backport the change into humble.

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Contributor Author
wep21 commented Dec 8, 2022

@adityapande-1995 What do you think about this?

@methylDragon
Copy link
Contributor
  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@methylDragon methylDragon merged commit ee932df into ros2:humble Dec 8, 2022
@wep21 wep21 deleted the backport-humble-338 branch December 8, 2022 19:51
@wep21
Copy link
Contributor Author
wep21 commented Dec 9, 2022

@clalancette @methylDragon @adityapande-1995
Could you create a new release for humble and do bloom-release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants
0