8000 add libopencv for old ubuntu by k-okada · Pull Request #4763 · ros/rosdistro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add libopencv for old ubuntu #4763

Merged
merged 1 commit into from
Jun 17, 2014
Merged

add libopencv for old ubuntu #4763

merged 1 commit into from
Jun 17, 2014

Conversation

k-okada
Copy link
Contributor
@k-okada k-okada commented Jun 17, 2014

No description provided.

@k-okada k-okada mentioned this pull request Jun 17, 2014
Closed
wjwwood added a commit that referenced this pull request Jun 17, 2014
@wjwwood
Merge pull request #4763 from k-okada/add_opencv
6775a0d 
add libopencv for old ubuntu
@wjwwood wjwwood merged commit 6775a0d into ros:master Jun 17, 2014
@k-okada k-okada deleted the add_opencv branch June 17, 2014 02:19
@k-okada
Copy link
Contributor Author
k-okada commented Jun 17, 2014

thanks!

@vrabaud
Copy link
Member
vrabaud commented Jun 17, 2014

I actually believe this is dangerous: if some of your packages depend on opencv2 and others on libopencv-dev, you will be linked to two different versions of OpenCV. Now, the latest OpenCV is LTS and extreme care is put in not breaking the API/ABI (cf http://upstream-tracker.org/versions/opencv.html) but you never know.
On Ubuntu < Saucy, you should use the OpenCV ROS package. If the motivation for this pull request is to have your branch work on Hydro+Groovy, you should instead depend on one common key that will pull the right OpenCV for you (like cv_bridge). If it's just to have Indigo build on Lucid, well, it is not supported.

@vrabaud vrabaud mentioned this pull request Jun 17, 2014
Closed
@k-okada
Copy link
Contributor Author
k-okada commented Jun 17, 2014

I see, we're using following code and it worked on groovy/hydro until a few days ago, but now it is not. Is there any change on opencv2 package?

pkg_check_modules(OpenCV opencv)
if (NOT OpenCV_FOUND)
  pkg_check_modules(OpenCV opencv-2.3.1)
  if (NOT OpenCV_FOUND)
    message(WARNING "opencv not found")
  endif()
endif()

k-okada added a commit to k-okada/hrpsys that referenced this pull request Jun 17, 2014
@k-okada
manifest.xml/package.xml: depends on cv_bridge instad of opencv (ros/…
f847deb 
…rosdistro#4763)
k-okada added a commit to k-okada/hrpsys that referenced this pull request Jun 17, 2014
@k-okada
manifest.xml/package.xml: depends on cv_bridge instad of opencv (ros/…
6853a19 
…rosdistro#4763)
@vrabaud
Copy link
Member
vrabaud commented Jun 17, 2014

That is indeed a regression. That will be fixed in #4769
Also, to be more future proof, you should simply do:

find_package(OpenCV)

@k-okada k-okada mentioned this pull request Jun 17, 2014
Merged
k-okada added a commit to k-okada/rosdistro that referenced this pull request Jun 17, 2014
@k-okada
revert ros#4763
adc8552
@k-okada k-okada mentioned this pull request Jun 17, 2014
Closed
@mikeferguson mikeferguson mentioned this pull request Jun 19, 2014
Closed
@tfoote tfoote mentioned this pull request Sep 14, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-okada @vrabaud @wjwwood
0