added math symbols and some standard data types for python evaluation #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -279,8 +280,11 @@ def _arg(resolved, a, args, context): | |||
| # context. We disable all the builtins, then add back True and False, and also | |||
| # add true and false for convenience (because we accept those lower-case strings | |||
| # as boolean values in XML). | |||
| _eval_dict={'true': True, 'false': False, 'True': True, 'False': False, '__builtins__': {}, | |||
| _eval_dict={'true': True, 'false': False, 'True': True, 'False': False, | |||
| '__builtins__': {k: __builtins__[k] for k in ['list', 'dict', 'map', 'str', 'float', 'int']}, | |||
| 'env': _eval_env, 'optenv': _eval_optenv, 'find': _eval_find} | |||
There was a problem hiding this comment.
This block becomes more difficult to read as it grows. Can you update it to:
eval_dict = {
'true': True, 'false': False,
'True': True, 'False': False,
'__builtins__': {k: __builtins__[k] for k in ['dict', 'float', 'int', 'list', 'map', 'str']},
'env': _eval_env, 'optenv': _eval_optenv,
'find': _eval_find
}
|
One test failed. |
|
The failed tests are unrelated to roslaunch: |
|
I was referring to the other one: http://build.ros.org/job/Kpr__ros_comm__ubuntu_xenial_amd64/61/testReport/junit/unit/test_substitution_args/test_resolve_args/ |
... and added appropriate unittests
fc3dec2 to
9888616
Compare
|
Oops. I missed that one. Hopefully fixed now. And squashed ;-) |
|
Thank you! |
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
added math symbols and some standard data types for python evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as discussed in #784 (comment)