Roslaunch performance improvement #682
Conversation
This reverts commit 72a9a91.
|
+1 |
|
Test passed. |
| @@ -90,7 +89,7 @@ def resolve_launch_arguments(args): | |||
| # try to resolve launch file in package first | |||
| if len(args) >= 2: | |||
| try: | |||
| resolved = roslaunch.resource_cache.find_resource(args[0], args[1]) | |||
| resolved = roslib.packages.find_resource(args[0], args[1]) | |||
There was a problem hiding this comment.
Can we use cached resource for find_resource? (not only find_node at https://github.com/ros/ros_comm/pull/682/files#diff-67998749e41c63572aa0901b6715e9a0R251)
There was a problem hiding this comment.
This function seems to be only called once. What is your use case where caching data here would improve anything?
There was a problem hiding this comment.
Actually I don't fully understand about rospack instance. I just wonder we can pass rospack instance to find_resource function which has cached source _path_to_package as previous implementation.
|
The finding paths is really fast. It's even faster than the implementation before in #676. |
|
Test passed. |
fa79ca8 to
f2a5838
Compare
Roslaunch performance improvement
|
Test passed. |
|
Test passed. |
|
@dirk-thomas , thanks a lot on solving this caching problem. However, we encountered a similar problem also in gazebo_ros_pkgs (ros-simulation/gazebo_ros_pkgs#362) when resolving URDF resources (package://) |
Roslaunch performance improvement
This reverts #676 and implements a different approach.