8000 Fix Building Encrypted Bags on Mac by smnogar · Pull Request #2114 · ros/ros_comm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Building Encrypted Bags on Mac #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
< 8000 input data-target="input-demux.source" id="context-commitish-filter-field" class="SelectMenu-input form-control" aria-owns="ref-list-branches" data-controls-ref-menu-id="ref-list-branches" autofocus autocomplete="off" aria-label="Find a branch" placeholder="Find a branch" type="text" >
from
Open

Fix Building Encrypted Bags on Mac #2114

wants to merge 1 commit into from

Conversation

smnogar
Copy link
Contributor
@smnogar smnogar commented Jan 5, 2021

Swaps out crypto library name with openssl. I didn't test to see if this change would also work on ubuntu, but it might.

fujitatomoya
fujitatomoya reviewed Jan 5, 2021
View reviewed changes
Copy link
Contributor
@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind sharing the actual problem that you have w/o this fix?

@smnogar
Copy link
Contributor Author
smnogar commented Jan 6, 2021

Ah, yes. I suppose I should provide more context. rosbag_storage currently fails to build by default on macOS because crypto is included in openssl when obtained via brew, so when looking for the crypto library cmake would fail. Previously I would just patch out encrypted bags altogether, but this change makes it so rosbag_storage and the encryption functionality correctly builds.

@sloretz
Copy link
Contributor
sloretz commented Apr 25, 2025

Thank you for the PR!

ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. To make sure this PR doesn't introduce any regressions please:

  • Describe how you tested this change
  • Recruit at least one more person to review this PR and try it out on their system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smnogar @sloretz @fujitatomoya
0