8000 Final edits before v1.1.2 by stitam · Pull Request #342 · ropensci/webchem · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Final edits 8000 before v1.1.2 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 6, 2021
Merged

Final edits before v1.1.2 #342

merged 13 commits into from
Dec 6, 2021

Conversation

stitam
Copy link
Contributor
@stitam stitam commented Dec 5, 2021 •
edited
Loading

Related to #341.

  • Increased version number to indicate a patch release
  • Changed some CTS examples and tests because it seems CTS cannot convert from chemical names at the moment
  • Moved test-bcps.R to the appropriate directory
  • Added a CRAN comments file for reviewers and marked it in .Rbuildignore
  • Fixed some URLs
  • Updated codemeta

@stitam
Copy link
Contributor Author
stitam commented Dec 5, 2021 •
edited
Loading

I have no idea why the checks are failing, R CMD check succeeds locally, all the tests pass.

Edit: a list object was directly converted to numeric. After unlisting it first the checks passed.

@stitam stitam merged commit 4337b05 into ropensci:master Dec 6, 2021
@stitam stitam deleted the new_release branch December 6, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stitam
0