8000 erroring · Issue #5 · ropensci/parzer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

erroring #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sckott opened this issue Feb 19, 2019 · 2 comments
Open

erroring #5

sckott opened this issue Feb 19, 2019 · 2 comments
Assignees
@AlbanSagouis
Milestone
v0.5

Comments

@sckott
Copy link
Contributor
sckott commented Feb 19, 2019

not sure how to error. some methods

  • if method gives back single output numeric/int/etc. then can error straight away
  • when method gives back data.frame: error straight away when found? or throw warnings? or put error messages in an "error" column in the output, and fill with NAs?
sckott added a commit that referenced this issue Feb 22, 2019
@sckott
for parse_lat and parse_lon, look for error in c++ side - giving NA w…
3fd87d4 
…hen occurs #5
@sckott sckott added this to the v0.2 milestone Aug 24, 2019
@sckott sckott modified the milestones: v0.2, v0.3, v0.4 Oct 7, 2020
@sckott sckott modified the milestones: v0.4, v0.5 Feb 15, 2021
@popovs
Copy link
popovs commented Dec 15, 2022 •
edited
Loading

not sure if this is the appropriate ticket to comment on, but it would be nice if parse_lat/parse_lon did not throw out a warning for detecting NA values in the vector. E.g.

> parzer::parse_lon(c(42.5, NA, 43.6, 56.3, -53, 0))

[1]  42.5   NaN  43.6  56.3 -53.0   0.0
Warning message:
In base::.Call(...) : no digits detected, got: NA

@AlbanSagouis
Copy link
Collaborator

Seems to be a good place to me. Thanks!
We are in the process of migrating from Rcpp to cpp11 so this might be something directly affected and if not, I agree there is room for improvement so I'll keep it in mind.

@AlbanSagouis AlbanSagouis self-assigned this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlbanSagouis AlbanSagouis

Labels
None yet
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
3 participants
@sckott @popovs @AlbanSagouis
0