8000 geotargets options / defaults update by brownag · Pull Request #30 · ropensci/geotargets · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

geotargets options / defaults update #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 15, 2024
Merged

geotargets options / defaults update #30

merged 7 commits into from
Mar 15, 2024

Conversation

brownag
Copy link
Contributor
@brownag brownag commented Mar 15, 2024 •
edited
Loading

Some updates to options following #19 for #26

njtierney
njtierney reviewed Mar 15, 2024
View reviewed changes
njtierney
njtierney approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator
@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@brownag @njtierney
Update R/geotargets-option.R
80ce7cf 
Co-authored-by: Nicholas Tierney <njtierney@users.noreply.github.com>
@njtierney
Copy link
Collaborator

Really nice work! I believe this resolves #25 #26 ?

It looks like it handles all we need for those issues to me. We can come back to #27 in a separate PR I think. Are you happy for me to merge?

@brownag
Copy link
Contributor Author
brownag commented Mar 15, 2024 •
edited
Loading

Really nice work! I believe this resolves #25 #26 ?

It looks like it handles all we need for those issues to me. We can come back to #27 in a separate PR I think. Are you happy for me to merge?

Thanks. Last thing was I realized that ENCODING as a default creation option for GTiff doesn't make sense... that is the default for terra::writeVector() but few or no raster drivers support it anyway. Should be good to merge if you are happy with it

@njtierney
Copy link
Collaborator

Yup! Awesome 🚀

@njtierney njtierney merged commit b16bea4 into ropensci:master Mar 15, 2024
This was referenced Mar 15, 2024
Closed
Closed
This was referenced Mar 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtierney njtierney njtierney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brownag @njtierney
0