Wayland/MacOS title bar color #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious what kitty looks like on your system without this change. For macOS, it is the "base" which matches our other terminal themes. |
|
I use GNOME + Wayland on Linux, but I don't use rose-pine for my DE, only for my terminal (and a few other programs). Here's what that looks like: In my opinion, it's better to configure the title bar in both places in case someone like me prefers to use just one. However, I haven't actually checked if my PR's colors line up with the colors it would have on GTK. |
|
I wouldn't mind adding this if the colour was "base" instead of "surface", only to not disrupt current users, at least on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
wayland_titlebar_colorandmacos_titlebar_color. Color is SurfaceWayland titlebars:
Main
Moon
Dawn
MacOS titlebars untested