Allow cleaning apt sources on provision #1578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know of any downsides to making this enabled by default? |
|
Ah it's an abundance of caution really. If people have made changes to their server manually, without using Trellis, their source list will be different to one that Trellis would recreate for them from scratch. I figured it was less risk to make it opt-in. |
swalkinshaw
reviewed
May 21, 2025
8000
Co-authored-by: Scott Walkinshaw <scott.walkinshaw@gmail.com>
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel: #1577
Motivation for this PR is in the related issue.
Considerations
apt_clean_sourcesto follow existing naming convention for APT varsapt_clean_sourceswith existing APT vars for logical groupingapt_clean_sourcesfalse by default so this is is opt-in and doesn't do unexpected things for people updating