Replace link for creating CSP #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should update this file based off the upstream source (https://github.com/h5bp/server-configs-nginx) |
|
I really thought I responded to this, oops. How about changing the text to match this one: https://github.com/h5bp/server-configs-nginx/blob/main/h5bp/security/content-security-policy.conf |
|
That works 👍 |
|
Sorry we weren't 100% clear before. We can't replace this entire file because there's other non-CSP settings. Specifically we should preserve the file as is, but replace the CSP related comment in this one only. |
|
Ah yes, seems to also have been an error from my side. So ready for the Friday to be honest. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I woke up this morning and decided to add CSP to the company website. Turns out that the checks changelog 7 year old link for this project takes you to a blog now.
So I looked around online for a similar site that is free to use. I found nothing.
Eventually I found a browser extension that allows you to create CSP by browsing around your website. I just tried it and so far it works great.
If you guys have a better site or extension, feel free using that instead :)
PS. What's going on with the community forum at the moment? I don't have Discord access and the message on the forum stating it's read only temporarily is really bare bones.