8000 gohack undo: restore old replace comment correctly by rogpeppe · Pull Request #31 · rogpeppe/gohack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

gohack undo: restore old replace comment correctly #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2018
Merged

gohack undo: restore old replace comment correctly #31

merged 1 commit into from
Oct 18, 2018

Conversation

rogpeppe
Copy link
Owner

When we did gohack undo, we were not keeping the old comment.
Also, we were wrongly omitting the "replace" token, which led
to invalid go.mod syntax being produced.

@rogpeppe
gohack undo: restore old replace comment correctly
32c38d0 
When we did `gohack undo`, we were not keeping the old comment.
Also, we were wrongly omitting the "replace" token, which led
to invalid go.mod syntax being produced.
@rogpeppe rogpeppe merged commit dad0e3a into master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rogpeppe
0