8000 Update lwjgl and fix macos arm64 natives by mourginakis · Pull Request #10 · rogerallen/hello_lwjgl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update lwjgl and fix macos arm64 natives #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update lwjgl and fix macos arm64 natives #10

wants to merge 8 commits into from

Conversation

mourginakis
Copy link
  • updated lwjgl to latest (3.3.1)
  • added dependencies for macos-arm64 (now runs on M1 Macbooks without error)
  • updated clojure to latest (1.11.1)

@mourginakis
Copy link
Author
mourginakis commented Sep 23, 2022 •
edited
Loading

I'm going to have to end up using a lot of LWJGL for my upcoming project, so I thought I might as well take this repo as far as I can. There's still a bit more that I wish to complete, but I did a lot to modernize this project to fit a wide variety of needs and platforms.

  • I updated everything to the latest version, fixed compiler errors, and added support for arm 64bit macs.
  • I added much better support for live code reloading the REPL, both in documentation and in code.
    • This means different behavior based on OS (specifically, whether or not to start the REPL in the main thread or the child thread, depending on platform)
    • Added a more robust (extensible) dispatching system, and another demo (a copy of alpha) that supports live code reloading of the 'draw' function. There's something really fun about watching these graphics update live right in front of you.
  • I got rid of the ugly load-str function call and replaced it with an (eval `(do ...))
  • I refactored the readme and added much more comprehensive information on compatibility issues with different operating systems and information on getting the repl/live coding to work

All changes/features work on both my 22.04 LTS Ubuntu machine and my MacOS Monterey M1, Including live code reloading. Using OpenJDK 17.

Things I want for the future:

Also, rogerallen, thanks a lot for this library. You did all the hard work. Let me know if you want me to change something.

@rogerallen
Copy link
Owner

Thanks for the pull request @mourginakis, this looks generally like a good set of changes.

As you might've guessed by how little I've modified this recently, I've not really kept up-to-date on Clojure so it may be a bit of time before I can get setup to merge this. I don't even have a Mac anymore, but I can try this out on Windows when I get things setup.

Cheers!

--Roger

@mourginakis
Copy link
Author
mourginakis commented Sep 26, 2022 •
edited
Loading

Glad I could contribute! This library has been incredibly helpful to me. I don't mind changing some code around too, if you have a certain preference for how things should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mourginakis @rogerallen
0