8000 set tuple for default value on union typedef by gunhanoral · Pull Request #318 · robshakir/pyangbind · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

set tuple for default value on union typedef #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2023
Merged

set tuple for default value on union typedef #318

merged 2 commits into from
Oct 8, 2023

Conversation

gunhanoral
Copy link
Contributor

Fix for #317

@JoseIgnacioTamayo
Copy link
Collaborator

Thanks.

Could you please add UnitTests at tests/union/union.yang so your code is covered.

I see we have such unions of string and uint, but we have not tried with default values yet.

@JoseIgnacioTamayo JoseIgnacioTamayo self-assigned this Oct 8, 2023
@JoseIgnacioTamayo JoseIgnacioTamayo self-requested a review October 8, 2023 15:20
@JoseIgnacioTamayo
Copy link
Collaborator

LGTM

JoseIgnacioTamayo
JoseIgnacioTamayo approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator
@JoseIgnacioTamayo JoseIgnacioTamayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoseIgnacioTamayo JoseIgnacioTamayo merged commit 00b8576 into robshakir:master Oct 8, 2023
@gunhanoral gunhanoral deleted the fix_issue_317 branch October 8, 2023 20:49
JoseIgnacioTamayo pushed a commit that referenced this pull request Dec 11, 2023
@gunhanoral @JoseIgnacioTamayo
set tuple for default value on union typedef (#318)
342d0bd 
Deal with Unions that have a default value

Fixes #317
---------

Authored-by: Gunhan Oral <gunhan.oral@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseIgnacioTamayo JoseIgnacioTamayo JoseIgnacioTamayo approved these changes

Assignees

@JoseIgnacioTamayo JoseIgnacioTamayo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunhanoral @JoseIgnacioTamayo
0