8000 Update helmfile.yaml example in README by Vad1mo · Pull Request #1189 · roboll/helmfile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update helmfile.yaml example in README #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in 8000 to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2020
Merged

Update helmfile.yaml example in README #1189

merged 5 commits into from
Apr 9, 2020

Conversation

Vad1mo
Copy link
Contributor
@Vad1mo Vad1mo commented Apr 8, 2020 •
edited
Loading

Added default comments into helmfile.yaml example

fixed some typos

Signed-off-by: Vadim Bauer vb@8gears.com

@Vad1mo
update docs
7a45ab1 
Signed-off-by: Vadim Bauer <vb@8gears.com>
mumoshu
mumoshu reviewed Apr 8, 2020
View reviewed changes
Copy link
Collaborator
@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is so close - Could you confirm my comments?

Vad1mo added 4 commits April 8, 2020 14:54
@Vad1mo
force: false
29adc0a 
Signed-off-by: Vadim Bauer <vb@8gears.com>
@Vad1mo
resolve comments
49882b3 
Signed-off-by: Vadim Bauer <vb@8gears.com>
@Vad1mo
set default for tls to false
12cc7da 
Signed-off-by: Vadim Bauer <vb@8gears.com>
@Vad1mo
adapt to discussion with Yusuke
0610bff 
Signed-off-by: Vadim Bauer <vb@8gears.com>
@Vad1mo
Copy link
Contributor Author
Vad1mo commented Apr 9, 2020

@mumoshu could you do another review?

mumoshu
mumoshu approved these changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator
@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution, @Vad1mo!

@mumoshu mumoshu changed the title update docs Update helmfile.yaml example in README Apr 9, 2020
@mumoshu mumoshu merged commit e0811df into roboll:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vad1mo @mumoshu
0