8000 fix test command for helm 3 by hoesler · Pull Request #1080 · roboll/helmfile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix test command for helm 3 #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

hoesler
Copy link
Contributor
@hoesler hoesler commented Jan 22, 2020

This PR sets command line options for helm test conditionally to helm version.

fixes #1050

@hoesler hoesler force-pushed the hotfix/helm3-test-command branch from cc4f3b8 to d25512a Compare January 22, 2020 19:23
Copy link
Collaborator
@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix! ☺️

@mumoshu mumoshu merged commit 9fab685 into roboll:master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helmfile test doesn't specify namespace
2 participants
0