8000 Resolve "Provide update functionality" by rockstaedt · Pull Request #31 · rockstaedt/commit-message-check · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Resolve "Provide update functionality" #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 11, 2023
Merged

Resolve "Provide update functionality" #31

merged 32 commits into from
Mar 11, 2023

Conversation

rockstaedt
Copy link
Owner

Closes #26

@rockstaedt
Define tests for update subcommand
9b3ff34
@rockstaedt
Implement happy update method
a22748c
@rockstaedt
Pass in local version
5cde4d5
@rockstaedt
Pass url to method
88f1864
@rockstaedt
Clean up tests
7457b58
@rockstaedt
Make request and compare versions
fc22eae
@rockstaedt
Outsource handler function
52bc488
@rockstaedt
Return 2 when response body empty
eb9ddf4
@rockstaedt
Check for status code of 200
314ae54
@rockstaedt
Check for http error code
4305991
10000 @rockstaedt
Outsource getting latest tag
e14bd9f
@rockstaedt
Print info when no newer version found
8f26ae6
@rockstaedt
Integrate new subcommand update
8823944
@rockstaedt
Extend manual by update
3df2763
@rockstaedt
Inform user about failed request
11fa595
@rockstaedt
Create file for install script
3510b4b
@rockstaedt
Handle error at creating
9e7376c
@rockstaedt
Open and truncate go binary
e497eaf
@rockstaedt
Put all config information into a struct
17bd3f5
@rockstaedt
Download file from BinaryUrl
65e5a4f
@rockstaedt
Handle http protocol error by returning 2
01ce3ac
@rockstaedt
Check status code of request
a56c659
@rockstaedt
Improve test description
6e8c1df
@rockstaedt
Build full url from parameters
b47ca56
@rockstaedt
Add struct field for latest tag
a0e4005
@rockstaedt
Outsource setting up url into function
5c7e474
@rockstaedt
Move struct definition to top
b7250f3
@rockstaedt
Outsource UpdateConfig struct into dedicated file
bfb1aea
@rockstaedt
Move function closer to usage
82e7809
@rockstaedt
Add log when update fails
23605cf
@rockstaedt rockstaedt requested a review from mschirmer1301 March 1, 2023 07:19
@rockstaedt rockstaedt self-assigned this Mar 1, 2023
@github-actions github-actions bot added the feature New feature or request label Mar 1, 2023
@rockstaedt rockstaedt marked this pull request as draft March 1, 2023 07:20
@rockstaedt
Make test independent of OS
7b013f8 
The github CLI runs on linux which was the reason why the pipeline
failed. The file was not served because the target URL was not correct
for a linux system.
@rockstaedt rockstaedt force-pushed the 26-update-subcommand branch from 799503e to 7b013f8 Compare March 1, 2023 07:40
@rockstaedt rockstaedt marked this pull request as ready for review March 1, 2023 07:41
@codecov-commenter
Copy 8000 link

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (eb2d7e1) 100.00% compared to head (7b013f8) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines          111       160   +49     
=========================================
+ Hits           111       160   +49
Impacted Files Coverage Δ
cmd/update.go 100.00% <100.00%> (ø)
util/manual.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rockstaedt rockstaedt merged commit 49ce682 into main Mar 11, 2023
@rockstaedt rockstaedt deleted the 26-update-subcommand branch March 11, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschirmer1301 mschirmer1301 Awaiting requested review from mschirmer1301

Assignees

@rockstaedt rockstaedt

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide update functionality
2 participants
@rockstaedt @codecov-commenter
0