-
Notifications
You must be signed in to change notification settings - Fork 194
binder: Install packages required for Jupyter to PDF convert #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Per jupyter/nbconvert#1328, these are the packages needed for Jupyter to be able to convert to PDF. Without it, you get unfriendly errors like [this] (2i2c-org/infrastructure#3188 (comment)). Given that the binder image includes jupyter, and texlive is included in the base, I hope it would be reasonable for the binder image to include enough texlive packages for PDF conversion to work. Otherwise, it works in RStudio but not in Jupyter.
db82bb2
to
0645caf
Compare
ok I'm confused now, because tlmgr isn't found in and the script is failing, but I do see |
I think If we want to add these packages to |
👍 Having support for Myst in binder would be nice. I think it makes sense to to call the |
It sets PATH appropriately
Let's see if this quietens shellcheck
104817a
to
5cafdb4
Compare
Yay, thanks @eitsupi. The julia test failure looks intermittent and unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, merging now.
Yay! Thank you, @eitsupi! I appreciate it :) Would this trigger a rebuild of the various rocker/binder: images? If not, would it be possible to kick off a rebuild of those? |
Today's new release of RStudio Server has already triggered a build. |
- Matches what we do in other images - Simplifies this image *a lot* - Knitting still takes time the *first time* even if we just switch to new base image. But rocker-org/rocker-versioned2#714 installs some of the texlive packages that are being installed the first time, and should speed things up. Ref 2i2c-org/infrastructure#3178
Per jupyter/nbconvert#1328, these are the packages needed for Jupyter to be able to convert to PDF. Without it, you get unfriendly errors like [this] (2i2c-org/infrastructure#3188 (comment)).
Given that the binder image includes jupyter, and texlive is included in the base, I hope it would be reasonable for the binder image to include enough texlive packages for PDF conversion to work. Otherwise, it works in RStudio but not in Jupyter.