8000 tests: Use semaphore install-package by glevand · Pull Request #3827 · rkt/rkt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

tests: Use semaphore install-package #3827

Merged
merged 1 commit into from
Oct 17, 2017
Merged

tests: Use semaphore install-package #3827

merged 1 commit into from
Oct 17, 2017

Conversation

glevand
Copy link
Contributor
@glevand glevand commented Oct 12, 2017

When running on semaphore use thier install-package to
take advantage of package caching.

@iaguis
Copy link
Member
iaguis commented Oct 13, 2017

Cool, I didn't know about this.

According to the docs we don't have to call apt-get update, should we try to remove that?

@squeed
Copy link
Contributor
squeed commented Oct 13, 2017

nice! LGTM

@glevand
tests: Use semaphore install-package
c7ab077 
When running on semaphore use thier install-package to
take advantage of package caching.

Signed-off-by: Geoff Levand <geoff@infradead.org>
@glevand
Copy link
Contributor Author
glevand commented Oct 17, 2017

@iaguis It seems if I remove all the apt-get update I get a failure: Unable to locate package gcc-5.

It seems safe to remove the first one for the standard ubuntu repos then do an apt-get update for the newly added repos though.

See https://semaphoreci.com/rkt/rkt/branches/pull-request-3827/builds/2

@iaguis iaguis merged commit 053f014 into rkt:master Oct 17, 2017
@glevand glevand deleted the for-merge-semaphore branch October 17, 2017 21:20
@iaguis iaguis added this to the 1.30.0 milestone Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iaguis iaguis iaguis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
3 participants
@glevand @iaguis @squeed
0