This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage1: handle docker group semantics #3792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
reviewed
Sep 8, 2017
stage1/init/common/pod.go
Outdated
| // if the image was converted from docker and set the GID to the UID in | ||
| // that case. | ||
| img := p.Images[ra.Name.String()] | ||
| if ConvertedFromDocker(img) && img.App.User == img.App.Group { |
There was a problem hiding this comment.
is it correct if the user and group are not specified in the ACI image but in the pod spec? (see test "Set invalid non-numerical app group.")
Shouldn't you use ra.App.User == ra.App.Group instead?
=== RUN TestPodManifest
--- FAIL: TestPodManifest (72.88s)
rkt_run_pod_manifest_test.go:1250: Expected "\"group2\" group not found" but not found: ExpectRegex didn't find regex '"group2" group not found'.
There was a problem hiding this comment.
It then breaks when the app is run with --user=foo
There was a problem hiding this comment.
We should check if the group in the pod spec is the same as the one in the image, it's only in that case that we want to emulate docker's behavior. If not, we assume the user wants what they mean (not docker's behavior).
Docker uses the UID as GID if you only specify the "user". In that case, docker2aci sets the group name to the user name because the appc spec requires both user and group to be set. This will fail because that group name won't be found in /etc/group. Let's detect if the image was converted from docker and set the GID to the UID in that case.
754d6e1 to
200bfdd
Compare
|
Updated. |
alban
approved these changes
Sep 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker uses the UID as GID if you only specify the "user".
In that case, docker2aci sets the group name to the user name because
the appc spec requires both user and group to be set. This will fail
because that group name won't be found in /etc/group.
Let's detect if the image was converted from docker and set the GID to
the UID in that case.