This repository was archived by the owner on Feb 24, 2020. It is now read-only.
rkt/pubkeys: print debug logs on discovery errors #3705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reorders log-printing and error-returning when pubkeys discovery fails, in order to print useful debugging information on error.
|
/cc @squeed |
|
@squeed @JulienBalestra @trusch @tesujimath @fabiokung if anybody has some spare minutes, I would like a review on this. |
squeed
approved these changes
Jun 19, 2017
|
LGTM Sent from my HTC One_M8 using FastHub |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorders log-printing and error-returning when pubkeys discovery
fails, in order to print useful debugging information on error.