This repository was archived by the owner on Feb 24, 2020. It is now read-only.
imagestore: Fix sql resource leaks #3682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using sql queries the rows iterator needs to be closed if the entire query
result is not iterated over. Failure to close the iterator results in resource
leakage.
Fixes errors like these seen with go1.8.1:
Too many goroutines running after integration test(s).
database/sql.(*Rows).awaitDone(0xc4201d9200, 0xd64000, 0xc4201e9b40)
database/sql/sql.go:2121
created by database/sql.(*Rows).initContextClose
database/sql/sql.go:2116
Signed-off-by: Geoff Levand <geoff@infradead.org>
lucab
approved these changes
May 19, 2017
|
Good catch indeed. I have been seeing this error with go 1.8 too, but haven't been able to track it down. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on dele
2E7A
ted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sql queries the rows iterator needs to be closed if the entire query
result is not iterated over. Failure to close the iterator results in resource
leakage.
Fixes errors like these seen with go1.8.1:
See: https://golang.org/pkg/database/sql/#Rows