-
Notifications
You must be signed in to change notification settings - Fork 880
Conversation
Can one of the admins verify this patch? |
/cc @jonboulle @alban |
I don't really get this because in most dialects of English rocket and
rockit should be largely homonymous.
In any case lucab didn't you want to stay away from non ascii?
Am 11.05.2017 14:53 schrieb "Luca Bruno" <notifications@github.com>:
… /cc @jonboulle <https://github.com/jonboulle> @alban
<https://github.com/alban>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3674 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACewN7Ke1CE_GPIsrcixopGiKTWGBn7fks5r4wTggaJpZM4NXwtu>
.
|
Yep, let's keep the README plain ASCII. @RaeesBhatti mind just removing the IPA part? |
README.md
Outdated
@@ -7,7 +7,7 @@ | |||
|
|||
 | |||
|
|||
rkt (pronounced _"rock-it"_) is a CLI for running application containers on Linux. rkt is designed to be secure, composable, and standards-based. | |||
rkt (pronounced like a _"rocket"_ - /ˈɹɑkɪt/) is a CLI for running application containers on Linux. rkt is designed to be secure, composable, and standards-based. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep just the like a _"rocket"_
part.
Ping, any updates on this? |
@lucab I've made the change. |
@RaeesBhatti thanks, looks fine now. Could you please just squash the two commits together and re-title it like I did for this PR? |
@lucab I don't think I have the access to do that. It will be done at the time of merge and "Only those with write access to this repository can merge pull requests." |
@RaeesBhatti sorry for the confusion, I don't mean merging this PR into master (me or some other maintainer will do that once everything is fine). What I meant is just to re-arrange the commits in the your branch in your repo, so that this PR only contains a single commit titled as above. |
Change `rkt` pronunciation from “rock-it” to “rocket” to match the rkt logo. Fixes #3673
@lucab Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
rkt
has an icon of a rocket but previously the official pronunciation was "rock-it" which is incompatible with the logo. This change fixes that.Fixes #3673