8000 docs: correct rkt pronunciation by RaeesBhatti · Pull Request #3674 · rkt/rkt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

docs: correct rkt pronunciation #3674

Merged
merged 1 commit into from
Jun 20, 2017
Merged

docs: correct rkt pronunciation #3674

merged 1 commit into from
Jun 20, 2017

Conversation

RaeesBhatti
Copy link
Contributor
@RaeesBhatti RaeesBhatti commented May 11, 2017

rkt has an icon of a rocket but previously the official pronunciation was "rock-it" which is incompatible with the logo. This change fixes that.

Fixes #3673

@ghost
Copy link
ghost commented May 11, 2017

Can one of the admins verify this patch?

@lucab lucab requested a review from jonboulle May 11, 2017 12:53
@lucab
Copy link
Member
lucab commented May 11, 2017

/cc @jonboulle @alban

@jonboulle
Copy link
Contributor
jonboulle commented May 11, 2017 via email

@lucab
Copy link
Member
lucab commented May 31, 2017

Yep, let's keep the README plain ASCII. @RaeesBhatti mind just removing the IPA part?

README.md Outdated
@@ -7,7 +7,7 @@

![rkt Logo](logos/rkt-horizontal-color.png)

rkt (pronounced _"rock-it"_) is a CLI for running application containers on Linux. rkt is designed to be secure, composable, and standards-based.
rkt (pronounced like a _"rocket"_ - /ˈɹɑkɪt/) is a CLI for running application containers on Linux. rkt is designed to be secure, composable, and standards-based.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep just the like a _"rocket"_ part.

@lucab lucab changed the title Correct rkt pronunciation and add IPA spelling docs: correct rkt pronunciation May 31, 2017
@lucab lucab added this to the 1.27.0 milestone May 31, 2017
@lucab
Copy link
Member
lucab commented Jun 15, 2017

Ping, any updates on this?

@RaeesBhatti
Copy link
Contributor Author

@lucab I've made the change.

@lucab
Copy link
Member
lucab commented Jun 18, 2017

@RaeesBhatti thanks, looks fine now. Could you please just squash the two commits together and re-title it like I did for this PR?

@lucab lucab modified the milestones: 1.28.0, 1.27.0 Jun 19, 2017
@RaeesBhatti
Copy link
Contributor Author

@lucab I don't think I have the access to do that. It will be done at the time of merge and "Only those with write access to this repository can merge pull requests."

@lucab
Copy link
Member
lucab commented Jun 19, 2017

@RaeesBhatti sorry for the confusion, I don't mean merging this PR into master (me or some other maintainer will do that once everything is fine). What I meant is just to re-arrange the commits in the your branch in your repo, so that this PR only contains a single commit titled as above.

Change `rkt` pronunciation from “rock-it” to “rocket” to match the rkt
logo.

Fixes #3673
@RaeesBhatti
Copy link
Contributor Author

@lucab Done

@lucab lucab removed the request for review from jonboulle June 20, 2017 06:53
Copy link
Member
@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucab lucab merged commit 08ee07a into rkt:master Jun 20, 2017
@RaeesBhatti RaeesBhatti deleted the patch-1 branch June 22, 2017 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The logo is incompatible with rkt pronunciation
3 participants
0