8000 Documentation: description of known logging issues by pskrzyns · Pull Request #2954 · rkt/rkt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Documentation: description of known logging issues #2954

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

pskrzyns
Copy link
Contributor
@pskrzyns pskrzyns commented Jul 20, 2016

Documentation changes to cover some logging caveats.

Closes #2640
Closes #2417

@lucab
Copy link
Member
lucab commented Jul 20, 2016

Thanks @pskrzyns, just let us (and @joshix) know once this is ready to check.

@@ -129,6 +129,18 @@ $ journalctl -M rkt-bc3c1451-2e81-45c6-aeb0-807db44e31b4 -t redis

Additionaly, logs can be programmatically accessed via the [sd-journal API](https://www.freedesktop.org/software/systemd/man/sd-journal.html).

In some rare situations whena application inside the pod is writing to stdout/stderr instead of journal (i.e. nginx) there is no way to obtain logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when an

@pskrzyns
Copy link
Contributor Author
pskrzyns commented Aug 5, 2016

@joshix @lucab updated

@@ -129,6 +129,27 @@ $ journalctl -M rkt-bc3c1451-2e81-45c6-aeb0-807db44e31b4 -t redis

Additionaly, logs can be programmatically accessed via the [sd-journal API](https://www.freedesktop.org/software/systemd/man/sd-journal.html).

Currently there are known 2 main issues with loggin in rkt:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/loggin/logging/

@lucab
Copy link
Member
lucab commented Aug 5, 2016

@pskrzyns thanks, I had a pass on it. I think some portions should be reworded a bit, as the details are a bit tricky and should be written down correctly to avoid even more confusion.

@lucab lucab added this to the v1.13.0 milestone Aug 5, 2016
@pskrzyns
Copy link
Contributor Author

@lucab PTAL

@pskrzyns pskrzyns changed the title [WIP] logging issues documentation logging issues documentation Aug 10, 2016
```
should be added to ```/etc/nginx/nginx.conf```

* If application inside the pod(i.e. newest etcd) writes directly to journald, it's resultig in its log entries being scoped by machind UUID.
Copy link
Contributor
@jellonek jellonek Aug 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before opening brace.
Also - "resulting".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/machind/machine/

@jellonek
Copy link
Contributor

LGTM. If it's a final version - please remove "do not merge" from issue description, and squash all commits.
Also PTAL on these two topics.

@@ -129,6 +129,28 @@ $ journalctl -M rkt-bc3c1451-2e81-45c6-aeb0-807db44e31b4 -t redis

Additionaly, logs can be programmatically accessed via the [sd-journal API](https://www.freedesktop.org/software/systemd/man/sd-journal.html).

Currently there are known 2 main issues with logging in rkt:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"two known main issues"

@pskrzyns pskrzyns force-pushed the logging_issues branch 3 times, most recently from 3ddd43b to 3b3840e Compare August 10, 2016 14:57
```
should be added to ```/etc/nginx/nginx.conf```

* If application inside the pod (i.e. newest etcd) writes directly to journald, it's resulting in its log entries being scoped by machine UUID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an application inside the pod writes directly to journald (e.g. some newer versions of etcd), the resulting log entries will not be written to stdout/stderr.

I don't really get the comment about the scoping.. doesn't that happen in every case? How is this any different to e.g. line 94 onwards above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonboulle it isn't different, your re-wording is the correct one.

Copy link
Contributor
@joshix joshix Aug 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Some applications, like newer version of etcd, write directly to journald. Such log entries will not be written to stdout or stderr. These logs can be retrieved by passing the machine ID to journalctl:"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @joshix

@lucab
Copy link
Member
lucab commented Aug 17, 2016

@pskrzyns ping for a rework.

@pskrzyns
Copy link
Contributor Author

@lucab so i should add etcd as example of application witch will cause problems in line 90 ?
https://github.com/coreos/rkt/pull/2954/files#diff-62c764709d1a6651340fe0b25a6aaf86R90

@lucab
Copy link
Member
lucab commented Aug 18, 2016

@pskrzyns I think that line 90 is ok, the journalctl part will work fine (it may just get some slightly different metadata). The issue to document here is that stdout/stderr here is blank, which in turn means that if you are running rkt as a systemd service you will not find entries in the service logs.

@lucab lucab modified the milestones: 1.14.0, v1.13.0 Aug 18, 2016
@s-urbaniak
Copy link
Contributor

@pskrzyns ping, will you be able add the requested bits? thanks!

Description of known issues with logging and instructions how to handle
them.

related to rkt#2640 and rkt#2417
@pskrzyns
Copy link
Contributor Author

Updated

@lucab
Copy link
Member
lucab commented Aug 31, 2016

LGTM

@lucab lucab changed the title logging issues documentation Documentation: description of known logging issues Aug 31, 2016
@lucab lucab merged commit 264caeb into rkt:master Aug 31, 2016
@pskrzyns pskrzyns deleted the logging_issues branch September 13, 2016 15:14
@lucab lucab unassigned joshix Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0